Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 94483002: Remove usage of deprecated V8 APIs from mojo (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M mojo/public/bindings/js/core.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/bindings/js/support.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/js/waiting_callback.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years ago (2013-11-28 09:46:27 UTC) #1
Mike West
LGTM.
7 years ago (2013-11-28 09:50:39 UTC) #2
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r237754 (presubmit successful).
7 years ago (2013-11-28 10:07:09 UTC) #3
abarth-chromium
7 years ago (2013-12-02 19:38:31 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698