Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: mojo/public/bindings/js/core.cc

Issue 94483002: Remove usage of deprecated V8 APIs from mojo (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/bindings/js/support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/bindings/js/core.cc
diff --git a/mojo/public/bindings/js/core.cc b/mojo/public/bindings/js/core.cc
index cb6a12ca7380c21c266e0d1bff5be81816720281..5ca062c7906caab47a704ca5b4b6fda894c0d297 100644
--- a/mojo/public/bindings/js/core.cc
+++ b/mojo/public/bindings/js/core.cc
@@ -56,7 +56,8 @@ gin::Dictionary ReadMessage(const gin::Arguments& args, MojoHandle handle,
return dictionary;
}
- v8::Handle<v8::ArrayBuffer> array_buffer = v8::ArrayBuffer::New(num_bytes);
+ v8::Handle<v8::ArrayBuffer> array_buffer =
+ v8::ArrayBuffer::New(args.isolate(), num_bytes);
std::vector<MojoHandle> handles(num_handles);
gin::ArrayBuffer buffer;
@@ -92,7 +93,7 @@ v8::Local<v8::ObjectTemplate> Core::GetTemplate(v8::Isolate* isolate) {
&g_wrapper_info);
if (templ.IsEmpty()) {
- templ = v8::ObjectTemplate::New();
+ templ = v8::ObjectTemplate::New(isolate);
templ->Set(gin::StringToSymbol(isolate, "close"),
gin::CreateFunctionTemplate(isolate,
« no previous file with comments | « no previous file | mojo/public/bindings/js/support.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698