Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 944823002: Revert of bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests (Closed)

Created:
5 years, 10 months ago by kaliamoorthi
Modified:
5 years, 10 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests (patchset #3 id:40001 of https://codereview.chromium.org/940693004/) Reason for revert: A related CL was reverted. Reverting this to ensure that this does not cause a failure due to the revert. Original issue's description: > bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests > > Previously they were more like integration tests that relied on > seccomp-bpf for installing the policies and executing them via live > system calls. > > BUG=449357 > > Committed: https://crrev.com/fdb1befee90e6849a1743fcacbe01521261a6366 > Cr-Commit-Position: refs/heads/master@{#317238} TBR=jln@chromium.org,mdempsky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449357 Committed: https://crrev.com/da7202250804e59b1584927bff20f658be70fda2 Cr-Commit-Position: refs/heads/master@{#317285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -180 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 9 chunks +94 lines, -169 lines 0 comments Download
M sandbox/linux/bpf_dsl/seccomp_macros.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/bpf_dsl/trap_registry.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kaliamoorthi
Created Revert of bpf_dsl: Change bpf_dsl_unittests into actual standalone unit tests
5 years, 10 months ago (2015-02-20 11:07:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944823002/1
5 years, 10 months ago (2015-02-20 11:08:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 11:08:56 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 11:09:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da7202250804e59b1584927bff20f658be70fda2
Cr-Commit-Position: refs/heads/master@{#317285}

Powered by Google App Engine
This is Rietveld 408576698