Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 944753004: Check for an active document in WebPluginContainerImpl::windowClipRect (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
esprehn, eae
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check for an active document in WebPluginContainerImpl::windowClipRect This is a speculative fix for crbug.com/459713. The exact cause is not clear in our crash reports but this change may fix an issue where the document is being destroyed. A Document's m_frame is only reset during destruction, after the lifecycle is set to be not active, so this patch adds a check for isActive. Additionally, this patch will move the crash location if the node's renderer is null. BUG=459713 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pdr.
5 years, 10 months ago (2015-02-20 07:35:57 UTC) #2
eae
LGTM. If this does end up fixing it I would like to see a test.
5 years, 10 months ago (2015-02-20 17:01:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944753004/1
5 years, 10 months ago (2015-02-20 17:02:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190582
5 years, 10 months ago (2015-02-20 21:55:01 UTC) #6
pdr.
5 years, 10 months ago (2015-02-23 03:35:01 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/947873002/ by pdr@chromium.org.

The reason for reverting is: This did not fix the crash but it gave us enough
info to fix this (in a followup)..

Powered by Google App Engine
This is Rietveld 408576698