Source/web/WebPluginContainerImpl.cpp - Issue 944753004: Check for an active document in WebPluginContainerImpl::windowClipRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 944753004: Check for an active document in WebPluginContainerImpl::windowClipRect (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPluginContainerImpl.cpp

diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp

index f9ada22df6e61510479b5c639df71d9d0a608d86..7f52011114eb2ca900bad3b8a0aeaf36112a1397 100644

--- a/Source/web/WebPluginContainerImpl.cpp

+++ b/Source/web/WebPluginContainerImpl.cpp

@@ -972,10 +972,7 @@ IntRect WebPluginContainerImpl::windowClipRect() const

IntRect clipRect =

convertToContainingWindow(IntRect(0, 0, width(), height()));

- // document().renderView() can be 0 when we receive messages from the

- // plugins while we are destroying a frame.

- // FIXME: Can we just check m_element->document().isActive() ?

- if (m_element->renderer()->document().renderView()) {

+ if (m_element->document().isActive()) {

// Take our element and get the clip rect from the enclosing layer and

// frame view.

clipRect.intersect(

« no previous file with comments | « no previous file | no next file » | no next file with comments »