Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 944733002: Sky should expose services provided to/by embedder (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
hansmuller, hansmuller1
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Sky should expose services provided to/by embedder These now appear on internals as takeServicesProvidedToEmbedder and takeServicesProvidedByEmbedder. When you call these functions, you get back the raw int that represents the handle. We'll need to wrap them up inside the Dart VM with the appropriate types. We can create a nice wrapper for that in a future CL. R=hansmuller@google.com, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3fa69e975b5a0eb5eb2bd80d78b45cdd52adbda6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -41 lines) Patch
M sky/examples/dart-mojo.sky View 1 chunk +1 line, -1 line 0 comments Download
D sky/framework/embedder.sky View 1 chunk +0 lines, -11 lines 0 comments Download
M sky/framework/inspector/inspector.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/shell.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/iframe-embed-vmc.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/document_view.h View 4 chunks +9 lines, -5 lines 0 comments Download
M sky/viewer/document_view.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M sky/viewer/internals.h View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/viewer/internals.cc View 4 chunks +29 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-20 01:39:13 UTC) #1
hansmuller1
LGTM
5 years, 10 months ago (2015-02-20 03:08:02 UTC) #3
abarth-chromium
5 years, 10 months ago (2015-02-20 05:16:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fa69e975b5a0eb5eb2bd80d78b45cdd52adbda6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698