Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: sky/viewer/document_view.h

Issue 944733002: Sky should expose services provided to/by embedder (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/services/network.sky ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/viewer/document_view.h
diff --git a/sky/viewer/document_view.h b/sky/viewer/document_view.h
index c71d2611f36f3793a2aa962b1de275926b6fc6ef..b463fe6f6144e7c15cf865b5a1372d56d9dcd5e6 100644
--- a/sky/viewer/document_view.h
+++ b/sky/viewer/document_view.h
@@ -22,6 +22,7 @@
#include "sky/engine/public/platform/ServiceProvider.h"
#include "sky/engine/public/web/WebFrameClient.h"
#include "sky/engine/public/web/WebViewClient.h"
+#include "sky/services/testing/test_harness.mojom.h"
#include "ui/events/gestures/gesture_types.h"
namespace mojo {
@@ -53,9 +54,6 @@ class DocumentView : public blink::ServiceProvider,
base::WeakPtr<DocumentView> GetWeakPtr();
blink::WebView* web_view() const { return web_view_; }
- mojo::ServiceProvider* imported_services() const {
- return imported_services_.get();
- }
mojo::Shell* shell() const { return shell_; }
@@ -70,6 +68,10 @@ class DocumentView : public blink::ServiceProvider,
void GetPixelsForTesting(std::vector<unsigned char>* pixels);
+ TestHarnessPtr TakeTestHarness();
+ mojo::ScopedMessagePipeHandle TakeServicesProvidedToEmbedder();
+ mojo::ScopedMessagePipeHandle TakeServicesProvidedByEmbedder();
+
private:
// WebViewClient methods:
void initializeLayerTreeView() override;
@@ -122,9 +124,11 @@ class DocumentView : public blink::ServiceProvider,
mojo::URLResponsePtr response_;
mojo::ServiceProviderImpl exported_services_;
- mojo::ServiceProviderPtr imported_services_;
+ mojo::InterfaceRequest<mojo::ServiceProvider> services_provided_to_embedder_;
+ mojo::ServiceProviderPtr embedder_provided_services_;
mojo::Shell* shell_;
- mojo::LazyInterfacePtr<mojo::NavigatorHost> navigator_host_;
+ TestHarnessPtr test_harness_;
+ mojo::NavigatorHostPtr navigator_host_;
blink::WebView* web_view_;
mojo::View* root_;
mojo::ViewManagerClientFactory view_manager_client_factory_;
« no previous file with comments | « sky/tests/services/network.sky ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698