Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 944583003: Deprecate Clients.getAll and introduce Clients.matchAll (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/modules/serviceworkers/Clients.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 844 matching lines...) Expand 10 before | Expand all | Expand 10 after
855 855
856 case SVGSVGElementUnsuspendRedraw: 856 case SVGSVGElementUnsuspendRedraw:
857 return "'SVGSVGElement.unsuspendRedraw()' is deprecated, please do not u se it. It is a no-op, as per SVG2 (https://svgwg.org/svg2-draft/struct.html#__sv g__SVGSVGElement__unsuspendRedraw)."; 857 return "'SVGSVGElement.unsuspendRedraw()' is deprecated, please do not u se it. It is a no-op, as per SVG2 (https://svgwg.org/svg2-draft/struct.html#__sv g__SVGSVGElement__unsuspendRedraw).";
858 858
859 case SVGSVGElementUnsuspendRedrawAll: 859 case SVGSVGElementUnsuspendRedrawAll:
860 return "'SVGSVGElement.unsuspendRedrawAll()' is deprecated, please do no t use it. It is a no-op, as per SVG2 (https://svgwg.org/svg2-draft/struct.html#_ _svg__SVGSVGElement__unsuspendRedrawAll)."; 860 return "'SVGSVGElement.unsuspendRedrawAll()' is deprecated, please do no t use it. It is a no-op, as per SVG2 (https://svgwg.org/svg2-draft/struct.html#_ _svg__SVGSVGElement__unsuspendRedrawAll).";
861 861
862 case ServiceWorkerClientPostMessage: 862 case ServiceWorkerClientPostMessage:
863 return "'Client.postMessage()' is an experimental API and may change. Se e https://github.com/slightlyoff/ServiceWorker/issues/609."; 863 return "'Client.postMessage()' is an experimental API and may change. Se e https://github.com/slightlyoff/ServiceWorker/issues/609.";
864 864
865 case ServiceWorkerClientsGetAll:
866 return "'Clients.getAll()' is deprecated and will be removed soon. Pleas e use 'Clients.matchAll()' instead.";
867
865 // Features that aren't deprecated don't have a deprecation message. 868 // Features that aren't deprecated don't have a deprecation message.
866 default: 869 default:
867 return String(); 870 return String();
868 } 871 }
869 } 872 }
870 873
871 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 874 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
872 { 875 {
873 ASSERT(feature >= firstCSSProperty); 876 ASSERT(feature >= firstCSSProperty);
874 ASSERT(feature <= lastCSSProperty); 877 ASSERT(feature <= lastCSSProperty);
(...skipping 27 matching lines...) Expand all
902 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 905 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
903 { 906 {
904 // FIXME: We may want to handle stylesheets that have multiple owners 907 // FIXME: We may want to handle stylesheets that have multiple owners
905 // http://crbug.com/242125 908 // http://crbug.com/242125
906 if (sheetContents && sheetContents->hasSingleOwnerNode()) 909 if (sheetContents && sheetContents->hasSingleOwnerNode())
907 return getFrom(sheetContents->singleOwnerDocument()); 910 return getFrom(sheetContents->singleOwnerDocument());
908 return 0; 911 return 0;
909 } 912 }
910 913
911 } // namespace blink 914 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | Source/modules/serviceworkers/Clients.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698