Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8397)

Unified Diff: chrome/test/BUILD.gn

Issue 944573003: Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | components/pdf/renderer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index e905563cf05ce7938f1b2ee737e193682df254c9..06b9aff07268eba9e9663bd55f3aedacfcc49555 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -380,7 +380,9 @@
}
if (is_mac) {
- datadeps += [ "//chrome" ]
+ datadeps = [
+ "//chrome",
+ ]
# TODO(mark): We really want this for all non-static library targets, but
# when we tried to pull it up to the common.gypi level, it broke other
@@ -877,6 +879,7 @@
]
sources += [
"../browser/media_galleries/fileapi/iphoto_data_provider_browsertest.cc",
+ "../browser/renderer_host/chrome_render_widget_host_view_mac_delegate_browsertest.cc",
"../browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm",
"../browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc",
]
@@ -887,13 +890,11 @@
# TODO(rouslan): This test depends on the custom dictionary UI,
# which is disabled on Mac.
- # TODO(GYP): This should be added somewhere first ...
- # "../browser/ui/webui/options/edit_dictionary_browsertest.js",
+ "../browser/ui/webui/options/edit_dictionary_browsertest.js",
# TODO(rouslan): This test depends on hunspell and we cannot run it
# on Mac, which does use hunspell by default.
- # TODO(GYP): This should be added somewhere first ...
- # "../browser/ui/webui/options/language_options_dictionary_download_browsertest.js",
+ "../browser/ui/webui/options/language_options_dictionary_download_browsertest.js",
# ProcessSingletonMac doesn"t do anything.
"../browser/process_singleton_browsertest.cc",
@@ -1550,7 +1551,7 @@
# on disk so it can pull from it.
deps += [
"//third_party/google_toolbox_for_mac",
- # "//third_party/ocmock", # TODO(GYP)
+ "//third_party/ocmock",
]
# TODO(mark): We really want this for all non-static library targets,
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | components/pdf/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698