Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 944343002: DevTools: migrate treeoutline from hasChildren to is/setExpandable(). (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 9 months ago
Reviewers:
caseq, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, blink-reviews-style_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: migrate treeoutline from hasChildren to is/setExpandable(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190768

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -101 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/components/ObjectPropertiesSection.js View 1 2 8 chunks +6 lines, -14 lines 1 comment Download
M Source/devtools/front_end/elements/ElementsTreeElement.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/EventListenersSidebarPane.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 5 chunks +6 lines, -7 lines 0 comments Download
M Source/devtools/front_end/network/XMLView.js View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/resources/ResourcesPanel.js View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sources/NavigatorView.js View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/RevisionHistoryView.js View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/PaintProfilerView.js View 1 2 2 chunks +2 lines, -6 lines 1 comment Download
M Source/devtools/front_end/ui/SidebarTreeElement.js View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/devtools/front_end/ui/treeoutline.js View 1 2 12 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
5 years, 10 months ago (2015-02-22 20:47:19 UTC) #2
sergeyv
lgtm
5 years, 10 months ago (2015-02-24 10:27:05 UTC) #3
sergeyv
https://codereview.chromium.org/944343002/diff/40001/Source/devtools/front_end/components/ObjectPropertiesSection.js File Source/devtools/front_end/components/ObjectPropertiesSection.js (right): https://codereview.chromium.org/944343002/diff/40001/Source/devtools/front_end/components/ObjectPropertiesSection.js#newcode180 Source/devtools/front_end/components/ObjectPropertiesSection.js:180: if (this.property.value) lets move this to constructor
5 years, 10 months ago (2015-02-24 13:03:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944343002/40001
5 years, 10 months ago (2015-02-24 17:34:04 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=190768
5 years, 10 months ago (2015-02-24 18:58:56 UTC) #7
caseq
5 years, 9 months ago (2015-03-06 09:35:30 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/944343002/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/timeline/PaintProfilerView.js (right):

https://codereview.chromium.org/944343002/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/timeline/PaintProfilerView.js:358:
TreeElement.call(this, "", !!this._logItem.params);
this._logItem is not set at this point.

Powered by Google App Engine
This is Rietveld 408576698