Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: Source/devtools/front_end/timeline/PaintProfilerView.js

Issue 944343002: DevTools: migrate treeoutline from hasChildren to is/setExpandable(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/PaintProfilerView.js
diff --git a/Source/devtools/front_end/timeline/PaintProfilerView.js b/Source/devtools/front_end/timeline/PaintProfilerView.js
index 3fe4622207404329f71678fd23de6e22497b2117..1a1d5e42f16462b92f1702b26c79e01d8e5bb8ac 100644
--- a/Source/devtools/front_end/timeline/PaintProfilerView.js
+++ b/Source/devtools/front_end/timeline/PaintProfilerView.js
@@ -355,7 +355,7 @@ WebInspector.PaintProfilerCommandLogView.prototype = {
*/
WebInspector.LogTreeElement = function(ownerView, logItem)
{
- TreeElement.call(this);
+ TreeElement.call(this, "", !!this._logItem.params);
caseq 2015/03/06 09:35:30 this._logItem is not set at this point.
this._logItem = logItem;
this._ownerView = ownerView;
this._filled = false;
@@ -365,14 +365,10 @@ WebInspector.LogTreeElement.prototype = {
onattach: function()
{
this._update();
- this.hasChildren = !!this._logItem.params;
},
- onexpand: function()
+ onpopulate: function()
{
- if (this._filled)
- return;
- this._filled = true;
for (var param in this._logItem.params)
WebInspector.LogPropertyTreeElement._appendLogPropertyItem(this, param, this._logItem.params[param]);
},

Powered by Google App Engine
This is Rietveld 408576698