[Password Manager] Fix password saving on Macys registration page

components/password_manager/core/browser/password_form_manager.h

Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 9256b35331ccafc6218a82243cb4bae4db296db3..a081ca380fecb958edb22d8f1e8d587a5a451373 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -44,10 +44,12 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // completely matching.
   enum MatchResultFlags {
     RESULT_NO_MATCH = 0,
-    RESULT_MANDATORY_ATTRIBUTES_MATCH = 1 << 0,  // Bare minimum to be a match.
-    RESULT_ACTION_MATCH = 1 << 1,                // Action URLs match too.
-    RESULT_COMPLETE_MATCH =
-        RESULT_MANDATORY_ATTRIBUTES_MATCH | RESULT_ACTION_MATCH
+    RESULT_ORIGINS_MATCH = 1 << 0,
+    RESULT_HTML_ATTRIBUTES_MATCH = 1 << 1,  // Bare minimum to be a match.

[vabr (Chromium), 2015/02/25 10:21:15]

The "bare minimum" comment is now a bit vague, since there are more than two
flags, and it is not clear which order the "minimum" is with respect to.
Probably just drop it, the code sides using these flags should be clear about
which flags constitute a good match.

[Garrett Casto, 2015/02/26 07:11:01]

Done.

+    RESULT_ACTION_MATCH = 1 << 2,           // Action URLs match too.
+    RESULT_COMPLETE_MATCH = RESULT_ORIGINS_MATCH |
+                            RESULT_HTML_ATTRIBUTES_MATCH |
+                            RESULT_ACTION_MATCH
   };
   // Use MatchResultMask to contain combinations of MatchResultFlags values.
   // It's a signed int rather than unsigned to avoid signed/unsigned mismatch
@@ -84,16 +86,6 @@ class PasswordFormManager : public PasswordStoreConsumer {
   // the same thread!
   bool HasCompletedMatching() const;
 
-  // Returns true if the observed form has both the current and new password
-  // fields, and the username field was not explicitly marked with
-  // autocomplete=username. In these cases it is not clear whether the username
-  // field is the right guess (often such change password forms do not contain
-  // the username at all), and the user should not be bothered with saving a
-  // potentially malformed credential. Once we handle change password forms
-  // correctly, or http://crbug.com/448351 gets implemented, this method should
-  // be replaced accordingly.
-  bool IsIgnorableChangePasswordForm() const;
-
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted() const;