components/autofill/core/common/save_password_progress_logger.cc - Issue 944163003: [Password Manager] Fix password saving on Macys registration page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 944163003: [Password Manager] Fix password saving on Macys registration page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 04e9e681c565b4b4300b1f737325fc1fc29fb369..677b997ae1e89091fc9a2a1e4799d61fd7a3b209 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -133,6 +133,8 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "Form manager found, exact match";

case SavePasswordProgressLogger::STRING_MATCH_WITHOUT_ACTION:

return "Form manager found, match except for action";

+ case SavePasswordProgressLogger::STRING_ORIGINS_MATCH:

+ return "Form manager found, only origins match";

case SavePasswordProgressLogger::STRING_MATCHING_NOT_COMPLETE:

return "No form manager has completed matching";

case SavePasswordProgressLogger::STRING_FORM_BLACKLISTED: