components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc - Issue 944163003: [Password Manager] Fix password saving on Macys registration page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

Issue 944163003: [Password Manager] Fix password saving on Macys registration page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/password_manager_browsertest.cc ('K') | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/autofill/core/common/save_password_progress_logger.h » ('j') | components/password_manager/core/browser/password_form_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

diff --git a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

index 5a72dafe7740cdd598b7b797b921ab0e71776f43..05dc714e3f7b9bc34acfd9744425d81c55056929 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

+++ b/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc

@@ -342,7 +342,10 @@ TEST_F(PasswordFormConversionUtilsTest, IdentifyingThreePasswordFields) {

{{"alpha", "", ""}, "password1", "alpha", "password2", ""},

{{"", "beta", "beta"}, "password1", "", "password2", "beta"},

{{"alpha", "beta", "beta"}, "password1", "alpha", "password2", "beta"},

- {{"beta", "beta", "alpha"}, "password3", "alpha", "password1", "beta"},

+ // If confirmed password comes first, assume that the third password

+ // field is related to security question, SSN, or credit card and ignore

+ // it.

+ {{"beta", "beta", "alpha"}, "", "", "password1", "beta"},

// If the fields are yet empty, we speculate that we will identify them as

// (current + new + new) once they are filled out, so we should classify

// them the same for now to keep our abstract interpretation less flaky.