|
Remove the concept of staticly positioned absolutes.
On the web, if you set position:absolute, but not
top/right/bottom/left, then the absolute goes where it
would have gone if it wasn't positioned. The use-cases for
this are slim and it introduces a lot of complexity to the
engine.
Also changes behavior in the presence of direction:rtl.
On the web, direction:rtl and top/left:auto would
sometimes set right:0. Instead we always position at
0,0 if the opposing values are auto.
This removes the code for this positioning and allows
simplifying a bunch of dirty bit handling code since
we don't need to setNeedsLayout if lines move around
or wrap differently.
The test cases did change their output, but the new
positioning all looks correct to me.
Committed: https://chromium.googlesource.com/external/mojo/+/dfc6cda892ebde7a1d1bd42760d87625abff0c0d
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+28 lines, -229 lines) |
Patch |
 |
M |
sky/engine/core/rendering/RenderBlock.cpp
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderBlockFlow.h
|
View
|
|
2 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderBlockFlow.cpp
|
View
|
|
3 chunks |
+0 lines, -29 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderBox.cpp
|
View
|
|
8 chunks |
+8 lines, -75 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderFlexibleBox.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderFlexibleBox.cpp
|
View
|
|
4 chunks |
+3 lines, -28 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderLayer.h
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderLayer.cpp
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/RenderParagraph.cpp
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/line/BreakingContextInlineHeaders.h
|
View
|
|
4 chunks |
+2 lines, -48 lines |
0 comments
|
Download
|
 |
M |
sky/engine/core/rendering/line/LineBreaker.cpp
|
View
|
|
1 chunk |
+4 lines, -6 lines |
1 comment
|
Download
|
 |
M |
sky/engine/core/rendering/style/RenderStyle.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/tests/layout/position-absolute-expected.txt
|
View
|
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
sky/tests/layout/position-absolute-pixels-expected.sky
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/tests/lowlevel/layers.sky
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
sky/tests/lowlevel/layers-expected.sky
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 5 (2 generated)
|