sky/engine/core/rendering/RenderParagraph.cpp - Issue 944073006: Remove the concept of staticly positioned absolutes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderParagraph.cpp

Issue 944073006: Remove the concept of staticly positioned absolutes. (Closed) Base URL: git@github.com:domokit/mojo.git@position

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderParagraph.cpp

diff --git a/sky/engine/core/rendering/RenderParagraph.cpp b/sky/engine/core/rendering/RenderParagraph.cpp

index 4d445a3cba52e44aeea4867db254fd9b5ed7b9d0..a427e45631aaf1f12c7142ba732c404d628a7607 100644

--- a/sky/engine/core/rendering/RenderParagraph.cpp

+++ b/sky/engine/core/rendering/RenderParagraph.cpp

@@ -824,9 +824,6 @@ void RenderParagraph::layoutRunsAndFloatsInRange(LineLayoutState& layoutState,

lineBox->setLineBreakInfo(endOfLine.object(), endOfLine.offset(), resolver.status());

}

- for (size_t i = 0; i < lineBreaker.positionedObjects().size(); ++i)

- setStaticPositions(this, lineBreaker.positionedObjects()[i]);

if (!layoutState.lineInfo().isEmpty())

layoutState.lineInfo().setFirstLine(false);