Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issue 944063002: Revert "Allow aria live regions to be announced when observed on a background tab." (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Allow aria live regions to be announced when observed on a background tab." There have been several user complaints regarding extra announcements coming most likely from background tabs. Especially with many tabs open, this can become an issue. We should reexamine some other way to surface this type of functionality in ChromeVox Next. The original cl was commited pre-Chrome migrated ChromeVox. TBR=dmazzoni@chromium.org Committed: https://crrev.com/077a6fdfc87b65a07f0c237b88c98e3447be9497 Cr-Commit-Position: refs/heads/master@{#317379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js View 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
David Tseng
5 years, 10 months ago (2015-02-20 18:51:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944063002/1
5 years, 10 months ago (2015-02-20 19:30:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 19:51:37 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 19:52:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/077a6fdfc87b65a07f0c237b88c98e3447be9497
Cr-Commit-Position: refs/heads/master@{#317379}

Powered by Google App Engine
This is Rietveld 408576698