Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4296)

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js

Issue 944063002: Revert "Allow aria live regions to be announced when observed on a background tab." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
index 885c925369e74bd6f09fd5a812f16eec3635efb5..b4d3c7ed60906c194a921f1997c8788a5ecf5c5e 100644
--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js
@@ -252,15 +252,11 @@ cvox.ChromeVoxEventWatcher.readFrom = function(store) {
* event was received.
*
* @param {Event} evt The event to be added to the events queue.
- * @param {boolean=} opt_ignoreVisibility Whether to ignore visibility
- * checking on the document. By default, this is set to false (so an
- * invisible document would result in this event not being added).
*/
-cvox.ChromeVoxEventWatcher.addEvent = function(evt, opt_ignoreVisibility) {
+cvox.ChromeVoxEventWatcher.addEvent = function(evt) {
// Don't add any events to the events queue if ChromeVox is inactive or the
- // page is hidden unless specified to not do so.
- if (!cvox.ChromeVox.isActive ||
- (document.webkitHidden && !opt_ignoreVisibility)) {
+ // page is hidden.
+ if (!cvox.ChromeVox.isActive || document.webkitHidden) {
return;
}
cvox.ChromeVoxEventWatcher.events_.push(evt);
@@ -486,7 +482,7 @@ cvox.ChromeVoxEventWatcher.mutationHandler = function(mutations) {
var evt = new window.Event('LiveRegion');
evt.navDescriptions = navDescriptions;
evt.assertive = assertive;
- cvox.ChromeVoxEventWatcher.addEvent(evt, true);
+ cvox.ChromeVoxEventWatcher.addEvent(evt);
return true;
});
};
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698