Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: base/debug/stack_trace_win.cc

Issue 943933005: Add dbghelp.dll that works on XP, and include in base.isolate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base.isolate ('k') | build/win/dbghelp_xp/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace_win.cc
diff --git a/base/debug/stack_trace_win.cc b/base/debug/stack_trace_win.cc
index 27661edccd6c44716267ec344a6cfcef5280efe7..55d55624088d59a0ac82f09da611b4ee48627ede 100644
--- a/base/debug/stack_trace_win.cc
+++ b/base/debug/stack_trace_win.cc
@@ -152,10 +152,6 @@ class SymbolContext {
init_error_ = ERROR_SUCCESS;
- // Work around a mysterious hang on Windows XP.
- if (base::win::GetVersion() < base::win::VERSION_VISTA)
- return;
-
// When transferring the binaries e.g. between bots, path put
// into the executable will get off. To still retrieve symbols correctly,
// add the directory of the executable to symbol search path.
« no previous file with comments | « base/base.isolate ('k') | build/win/dbghelp_xp/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698