tools/metrics/histograms/histograms.xml - Issue 943823002: Add UMA histogram for whether page loads are mobile optimized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 943823002: Add UMA histogram for whether page loads are mobile optimized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 56132cd64257ecde6ff1ba10a7b93d0e0a9ef770..4d94ab0b616740176684adf52b6e03ce336f3fd9 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -15242,6 +15242,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Navigation.IsMobileOptimized" enum="Boolean">

Ilya Sherman 2015/02/19 23:51:26 nit: Please associate a custom boolean enum, so th

nyquist 2015/02/20 01:43:55 Done.

+ <owner>cjhopman@chromium.org</owner>

+ <owner>nyquist@chromium.org</owner>

+ <summary>

+ Signifies if a succesfully finished page load for the main frame has the

Ilya Sherman 2015/02/19 23:51:25 Optional nit: IMO "whether" reads better than "if"

nyquist 2015/02/20 01:43:55 Done. Agreed.

+ mobile optimized hint set.

+ </summary>

+</histogram>

<owner>cbentzel@chromium.org</owner>

<owner>davidben@chromium.org</owner>