Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 943823002: Add UMA histogram for whether page loads are mobile optimized (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 1616b717f64c62e4414f0d72f5207db76c7e3fb3..7a54122c2f5686c2c36c3ed526a400b285b72340 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -56,6 +56,7 @@ import org.chromium.base.ObserverList;
import org.chromium.base.ObserverList.RewindableIterator;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.content.R;
import org.chromium.content.browser.ScreenOrientationListener.ScreenOrientationObserver;
import org.chromium.content.browser.accessibility.AccessibilityInjector;
@@ -766,6 +767,14 @@ public class ContentViewCore
}
@Override
+ public void didFinishLoad(long frameId, String validatedUrl, boolean isMainFrame) {
+ if (isMainFrame) {
jdduke (slow) 2015/02/19 23:39:59 I wonder about the timing of this call relative to
+ RecordHistogram.recordBooleanHistogram(
+ "Navigation.MobileOptimized", getIsMobileOptimizedHint());
+ }
+ }
+
+ @Override
public void renderProcessGone(boolean wasOomProtected) {
hidePopupsAndClearSelection();
resetScrollInProgress();
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698