Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(550)

Issue 943813002: cc: Add TaskGraphRunner sub-namespaces with task concurrency limits. (Closed)

Created:
5 years, 7 months ago by vmiura
Modified:
4 years, 7 months ago
Reviewers:
reveman, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add TaskGraphRunner sub-namespaces with task concurrency limits. This change splits task namespaces into separate sub-namespaces that can have individual ready-to-run state. A graph node can specify a maximum number of tasks it can run concurrently with in the same sub-namespace. GpuTileTaskRunner uses it's own sub-namespace for raster tasks with a concurrency limit of 1 task. Other TTRs & tasks use a default sub-namespace with a concurrency limit of 16 tasks. BUG=459760 BUG=454500

Patch Set 1 #

Patch Set 2 : Basic updates to tests. #

Patch Set 3 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -102 lines) Patch
M cc/resources/bitmap_tile_task_worker_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/resources/gpu_tile_task_worker_pool.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/resources/gpu_tile_task_worker_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/resources/one_copy_tile_task_worker_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/resources/pixel_buffer_tile_task_worker_pool.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/resources/task_graph_runner.h View 6 chunks +57 lines, -12 lines 6 comments Download
M cc/resources/task_graph_runner.cc View 1 2 12 chunks +125 lines, -65 lines 1 comment Download
M cc/resources/task_graph_runner_perftest.cc View 1 2 chunks +10 lines, -3 lines 0 comments Download
M cc/resources/task_graph_runner_unittest.cc View 1 1 chunk +8 lines, -3 lines 1 comment Download
M cc/resources/tile_task_worker_pool.h View 3 chunks +9 lines, -2 lines 0 comments Download
M cc/resources/tile_task_worker_pool.cc View 3 chunks +12 lines, -5 lines 1 comment Download
M cc/resources/zero_copy_tile_task_worker_pool.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 12 (2 generated)
vmiura
PTAL
5 years, 7 months ago (2015-02-19 22:50:15 UTC) #2
danakj
I think david needs to review this at a high level to verify this makes ...
5 years, 7 months ago (2015-02-23 18:45:01 UTC) #3
vmiura
danakj: Thanks. I'll wait for David's general Okay then do the final cleanup.
5 years, 7 months ago (2015-02-23 18:54:31 UTC) #4
reveman
Could we use a different name than sub-namespace and have the concurrency limit always be ...
5 years, 7 months ago (2015-02-23 20:58:24 UTC) #5
vmiura
On 2015/02/23 20:58:24, reveman wrote: > Could we use a different name than sub-namespace and ...
5 years, 7 months ago (2015-02-23 21:54:11 UTC) #6
vmiura
On 2015/02/23 21:54:11, vmiura wrote: > On 2015/02/23 20:58:24, reveman wrote: > > Could we ...
5 years, 7 months ago (2015-02-23 22:02:36 UTC) #7
reveman
On 2015/02/23 at 22:02:36, vmiura wrote: > On 2015/02/23 21:54:11, vmiura wrote: > > On ...
5 years, 7 months ago (2015-02-23 22:08:18 UTC) #8
vmiura
On 2015/02/23 22:08:18, reveman wrote: > On 2015/02/23 at 22:02:36, vmiura wrote: > > On ...
5 years, 7 months ago (2015-02-24 00:11:59 UTC) #9
vmiura
Eric: I think I can close this since you've handled this elsewhere?
4 years, 9 months ago (2015-12-29 01:05:49 UTC) #11
ericrk
4 years, 8 months ago (2016-01-15 23:07:52 UTC) #12
On 2015/12/29 at 01:05:49, vmiura wrote:
> Eric: I think I can close this since you've handled this elsewhere?

Yup - handling this in crrev.com/1493703004 and crrev.com/1576133002.

Powered by Google App Engine
This is Rietveld 408576698