Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 943633003: [WebView] Remove onFailure from VisualStateCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Keep callback invocation from ~RenderFrameHostImpl Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index e6cc05197d3a25613468d2938787f3f54da90757..ed63dd08b1830d2c11279307a20b395eb83c7d7d 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -203,7 +203,7 @@ RenderFrameHostImpl::~RenderFrameHostImpl() {
swapout_event_monitor_timeout_.reset();
for (const auto& iter: visual_state_callbacks_) {
- iter.second.Run(false);
+ iter.second.Run();
piman 2015/02/24 21:51:23 I think we want to keep the bool here. We would wa
}
if (render_widget_host_)
@@ -1127,7 +1127,7 @@ void RenderFrameHostImpl::OnJavaScriptExecuteResponse(
void RenderFrameHostImpl::OnVisualStateResponse(uint64 id) {
auto it = visual_state_callbacks_.find(id);
if (it != visual_state_callbacks_.end()) {
- it->second.Run(true);
+ it->second.Run();
visual_state_callbacks_.erase(it);
} else {
NOTREACHED() << "Received script response for unknown request";
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | content/public/browser/render_frame_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698