android_webview/native/aw_contents.cc - Issue 943633003: [WebView] Remove onFailure from VisualStateCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.cc

Issue 943633003: [WebView] Remove onFailure from VisualStateCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep callback invocation from ~RenderFrameHostImpl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.cc

diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc

index c3c311096bd021e7166ad44ef521c46255ae6536..3e58cb2995a6ead1e277f9606c65a061e6225eb8 100644

--- a/android_webview/native/aw_contents.cc

+++ b/android_webview/native/aw_contents.cc

@@ -1037,14 +1037,13 @@ void AwContents::EnableOnNewPicture(JNIEnv* env,

namespace {

void InvokeVisualStateCallback(const JavaObjectWeakGlobalRef& java_ref,

long request_id,

- ScopedJavaGlobalRef<jobject>* callback,

- bool result) {

+ ScopedJavaGlobalRef<jobject>* callback) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = java_ref.get(env);

if (obj.is_null())

return;

Java_AwContents_invokeVisualStateCallback(

- env, obj.obj(), callback->obj(), request_id, result);

+ env, obj.obj(), callback->obj(), request_id);

}

} // namespace