android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java - Issue 943633003: [WebView] Remove onFailure from VisualStateCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

Issue 943633003: [WebView] Remove onFailure from VisualStateCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep callback invocation from ~RenderFrameHostImpl Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/native/aw_contents.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

index 877de7aaf733ea20025201980c37804f13b4edf0..5c322f6b794fb048054cf079dfb1a78ff1495bfc 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/VisualStateTest.java

@@ -54,11 +54,6 @@ public class VisualStateTest extends AwTestBase {

assertEquals(requestId, id);

ch.notifyCalled();

}

- @Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

});

}

});

@@ -85,11 +80,6 @@ public class VisualStateTest extends AwTestBase {

awContentsRef.get().insertVisualStateCallback(requestId,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

assertEquals(requestId, id);

Bitmap blueScreenshot = GraphicsTestUtils

@@ -142,11 +132,6 @@ public class VisualStateTest extends AwTestBase {

awContentsRef.get().insertVisualStateCallback(10,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap blueScreenshot = GraphicsTestUtils.drawAwContents(

awContentsRef.get(), 100, 100);

@@ -186,11 +171,6 @@ public class VisualStateTest extends AwTestBase {

awContents.insertVisualStateCallback(20,

new VisualStateCallback() {

@Override

- public void onFailure(long id) {

- fail("onFailure received");

- }

- @Override

public void onComplete(long id) {

Bitmap redScreenshot = GraphicsTestUtils.drawAwContents(

awContents, 100, 100);