Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 943533002: Properly ifdef sync code in password_manager (Closed)

Created:
5 years, 10 months ago by Jiang Jiang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly ifdef sync code in password_manager Fix one misplaced header include and use PASSWORD_MANAGER_ENABLE_SYNC macro to properly guard the other place of sync usage to fix a linking issue when PASSWORD_MANAGER_ENABLE_SYNC is disabled. Committed: https://crrev.com/e13de14ab0eba806c7e065bbb56e1a66ae3ee5e7 Cr-Commit-Position: refs/heads/master@{#317043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/passwords/password_manager_presenter.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_store.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jiang Jiang
PTAL.
5 years, 10 months ago (2015-02-19 13:00:46 UTC) #2
Mike West
LGTM.
5 years, 10 months ago (2015-02-19 13:02:23 UTC) #4
Jiang Jiang
On 2015/02/19 13:02:23, Mike West wrote: > LGTM. Well, that was quick, thanks!
5 years, 10 months ago (2015-02-19 13:03:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943533002/1
5 years, 10 months ago (2015-02-19 13:04:08 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 14:22:44 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 14:23:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e13de14ab0eba806c7e065bbb56e1a66ae3ee5e7
Cr-Commit-Position: refs/heads/master@{#317043}

Powered by Google App Engine
This is Rietveld 408576698