Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: chrome/browser/ui/passwords/password_manager_presenter.cc

Issue 943533002: Properly ifdef sync code in password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/password_manager_presenter.cc
diff --git a/chrome/browser/ui/passwords/password_manager_presenter.cc b/chrome/browser/ui/passwords/password_manager_presenter.cc
index f74241d85f54381fc0f494a6fa5e20e09f46f1aa..de2a4c7f003ee2f8c4b0c289512bb96caf131dd5 100644
--- a/chrome/browser/ui/passwords/password_manager_presenter.cc
+++ b/chrome/browser/ui/passwords/password_manager_presenter.cc
@@ -132,6 +132,7 @@ void PasswordManagerPresenter::RequestShowPassword(size_t index) {
return;
}
+#if defined(PASSWORD_MANAGER_ENABLE_SYNC)
if (password_manager_sync_metrics::IsSyncAccountCredential(
password_view_->GetProfile(),
base::UTF16ToUTF8(password_list_[index]->username_value),
@@ -139,6 +140,7 @@ void PasswordManagerPresenter::RequestShowPassword(size_t index) {
content::RecordAction(
base::UserMetricsAction("PasswordManager_SyncCredentialShown"));
}
+#endif
// Call back the front end to reveal the password.
password_view_->ShowPassword(index, password_list_[index]->password_value);
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698