Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 943483003: Gracefully handle screen.orientation access over unsupported frames. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Gracefully handle screen.orientation access over unsupported frames. WebLocalFrame-hosted LocalFrames install screen orientation support; WebPagePopup-hosted ones reasonably don't. The window of the latter kind are accessible in non-production builds, so correctly handle any attempted access to screen.orientation for these. R=haraken,mlamouri BUG=459284 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190479

Patch Set 1 #

Patch Set 2 : Switch to testharness.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
A LayoutTests/screen_orientation/screenorientation-unsupported-no-crash.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientation.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
sof
Please take a look. Initially suspected this was due to recent frame detachment changes, but ...
5 years, 10 months ago (2015-02-19 10:44:59 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-19 10:48:51 UTC) #3
mlamouri (slow - plz ping)
What do you mean by "unsupported frames"? Also, screen_orientation/ tests are using test-harness. Could you ...
5 years, 10 months ago (2015-02-19 11:06:16 UTC) #4
sof
On 2015/02/19 11:06:16, Mounir Lamouri wrote: > What do you mean by "unsupported frames"? > ...
5 years, 10 months ago (2015-02-19 11:07:23 UTC) #5
mlamouri (slow - plz ping)
On 2015/02/19 at 11:07:23, sigbjornf wrote: > On 2015/02/19 11:06:16, Mounir Lamouri wrote: > > ...
5 years, 10 months ago (2015-02-19 11:15:16 UTC) #6
sof
On 2015/02/19 11:15:16, Mounir Lamouri wrote: > On 2015/02/19 at 11:07:23, sigbjornf wrote: > > ...
5 years, 10 months ago (2015-02-19 11:21:20 UTC) #7
mlamouri (slow - plz ping)
On 2015/02/19 at 11:21:20, sigbjornf wrote: > On 2015/02/19 11:15:16, Mounir Lamouri wrote: > > ...
5 years, 10 months ago (2015-02-19 12:03:26 UTC) #8
sof
On 2015/02/19 12:03:26, Mounir Lamouri wrote: > On 2015/02/19 at 11:21:20, sigbjornf wrote: > > ...
5 years, 10 months ago (2015-02-19 12:08:20 UTC) #9
mlamouri (slow - plz ping)
On 2015/02/19 at 12:08:20, sigbjornf wrote: > On 2015/02/19 12:03:26, Mounir Lamouri wrote: > > ...
5 years, 10 months ago (2015-02-19 12:11:03 UTC) #10
sof
On 2015/02/19 12:11:03, Mounir Lamouri wrote: > On 2015/02/19 at 12:08:20, sigbjornf wrote: > > ...
5 years, 10 months ago (2015-02-19 13:48:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943483003/20001
5 years, 10 months ago (2015-02-19 14:07:45 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 15:25:11 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190479

Powered by Google App Engine
This is Rietveld 408576698