Gracefully handle screen.orientation access over unsupported frames.

Gracefully handle screen.orientation access over unsupported frames.

WebLocalFrame-hosted LocalFrames install screen orientation support;
WebPagePopup-hosted ones reasonably don't. The window of the latter
kind are accessible in non-production builds, so correctly handle
any attempted access to screen.orientation for these.

R=haraken,mlamouri
BUG=459284
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190479

[sof, 2015-02-19 10:44:59]

sigbjornf@opera.com changed reviewers:
+ haraken@chromium.org, mlamouri@chromium.org

[sof, 2015-02-19 10:44:59]

Please take a look.

Initially suspected this was due to recent frame detachment changes, but not so.

[haraken, 2015-02-19 10:48:51]

LGTM

[mlamouri (slow - plz ping), 2015-02-19 11:06:16]

What do you mean by "unsupported frames"?

Also, screen_orientation/ tests are using test-harness. Could you use that
framework for the test if feasible?

[sof, 2015-02-19 11:07:23]

On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> What do you mean by "unsupported frames"?
> 
> Also, screen_orientation/ tests are using test-harness. Could you use that
> framework for the test if feasible?

See the test for notion of unsupported frames?

[mlamouri (slow - plz ping), 2015-02-19 11:15:16]

On 2015/02/19 at 11:07:23, sigbjornf wrote:
> On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > What do you mean by "unsupported frames"?
> > 
> > Also, screen_orientation/ tests are using test-harness. Could you use that
> > framework for the test if feasible?
> 
> See the test for notion of unsupported frames?

Hmm, I can the question should be why are popup menu windows unsupported?

[sof, 2015-02-19 11:21:20]

On 2015/02/19 11:15:16, Mounir Lamouri wrote:
> On 2015/02/19 at 11:07:23, sigbjornf wrote:
> > On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > > What do you mean by "unsupported frames"?
> > > 
> > > Also, screen_orientation/ tests are using test-harness. Could you use that
> > > framework for the test if feasible?
> > 
> > See the test for notion of unsupported frames?
> 
> Hmm, I can the question should be why are popup menu windows unsupported?

We create&use these windows in order to implement our forms offering, no user
code runs there (nor is the window exposed in production builds.) Do we need to
support screen orientation to display a monthly calendar?

[mlamouri (slow - plz ping), 2015-02-19 12:03:26]

On 2015/02/19 at 11:21:20, sigbjornf wrote:
> On 2015/02/19 11:15:16, Mounir Lamouri wrote:
> > On 2015/02/19 at 11:07:23, sigbjornf wrote:
> > > On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > > > What do you mean by "unsupported frames"?
> > > > 
> > > > Also, screen_orientation/ tests are using test-harness. Could you use
that
> > > > framework for the test if feasible?
> > > 
> > > See the test for notion of unsupported frames?
> > 
> > Hmm, I can the question should be why are popup menu windows unsupported?
> 
> We create&use these windows in order to implement our forms offering, no user
code runs there (nor is the window exposed in production builds.) Do we need to
support screen orientation to display a monthly calendar?

I'm fine with that. I am just wondering how we end up with no
ScreenOrientationController for those.

[sof, 2015-02-19 12:08:20]

On 2015/02/19 12:03:26, Mounir Lamouri wrote:
> On 2015/02/19 at 11:21:20, sigbjornf wrote:
> > On 2015/02/19 11:15:16, Mounir Lamouri wrote:
> > > On 2015/02/19 at 11:07:23, sigbjornf wrote:
> > > > On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > > > > What do you mean by "unsupported frames"?
> > > > > 
> > > > > Also, screen_orientation/ tests are using test-harness. Could you use
> that
> > > > > framework for the test if feasible?
> > > > 
> > > > See the test for notion of unsupported frames?
> > > 
> > > Hmm, I can the question should be why are popup menu windows unsupported?
> > 
> > We create&use these windows in order to implement our forms offering, no
user
> code runs there (nor is the window exposed in production builds.) Do we need
to
> support screen orientation to display a monthly calendar?
> 
> I'm fine with that. I am just wondering how we end up with no
> ScreenOrientationController for those.

The frames for those aren't backed by WebLocalFrames, but mere WebPagePopups.
The former provides various custom supplements to the LocalFrame when
initialized.

[mlamouri (slow - plz ping), 2015-02-19 12:11:03]

On 2015/02/19 at 12:08:20, sigbjornf wrote:
> On 2015/02/19 12:03:26, Mounir Lamouri wrote:
> > On 2015/02/19 at 11:21:20, sigbjornf wrote:
> > > On 2015/02/19 11:15:16, Mounir Lamouri wrote:
> > > > On 2015/02/19 at 11:07:23, sigbjornf wrote:
> > > > > On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > > > > > What do you mean by "unsupported frames"?
> > > > > > 
> > > > > > Also, screen_orientation/ tests are using test-harness. Could you
use
> > that
> > > > > > framework for the test if feasible?
> > > > > 
> > > > > See the test for notion of unsupported frames?
> > > > 
> > > > Hmm, I can the question should be why are popup menu windows
unsupported?
> > > 
> > > We create&use these windows in order to implement our forms offering, no
user
> > code runs there (nor is the window exposed in production builds.) Do we need
to
> > support screen orientation to display a monthly calendar?
> > 
> > I'm fine with that. I am just wondering how we end up with no
> > ScreenOrientationController for those.
> 
> The frames for those aren't backed by WebLocalFrames, but mere WebPagePopups.
The former provides various custom supplements to the LocalFrame when
initialized.

Maybe this could be added to the CL description?

Anyway, thanks for the explanations and lgtm

[sof, 2015-02-19 13:42:26]

New patchsets have been uploaded after l-g-t-m from
haraken@chromium.org,mlamouri@chromium.org

[sof, 2015-02-19 13:48:29]

On 2015/02/19 12:11:03, Mounir Lamouri wrote:
> On 2015/02/19 at 12:08:20, sigbjornf wrote:
> > On 2015/02/19 12:03:26, Mounir Lamouri wrote:
> > > On 2015/02/19 at 11:21:20, sigbjornf wrote:
> > > > On 2015/02/19 11:15:16, Mounir Lamouri wrote:
> > > > > On 2015/02/19 at 11:07:23, sigbjornf wrote:
> > > > > > On 2015/02/19 11:06:16, Mounir Lamouri wrote:
> > > > > > > What do you mean by "unsupported frames"?
> > > > > > > 
> > > > > > > Also, screen_orientation/ tests are using test-harness. Could you
> use
> > > that
> > > > > > > framework for the test if feasible?
> > > > > > 
> > > > > > See the test for notion of unsupported frames?
> > > > > 
> > > > > Hmm, I can the question should be why are popup menu windows
> unsupported?
> > > > 
> > > > We create&use these windows in order to implement our forms offering, no
> user
> > > code runs there (nor is the window exposed in production builds.) Do we
need
> to
> > > support screen orientation to display a monthly calendar?
> > > 
> > > I'm fine with that. I am just wondering how we end up with no
> > > ScreenOrientationController for those.
> > 
> > The frames for those aren't backed by WebLocalFrames, but mere
WebPagePopups.
> The former provides various custom supplements to the LocalFrame when
> initialized.
> 
> Maybe this could be added to the CL description?
> 
> Anyway, thanks for the explanations and lgtm

Thanks; switched to testharness.js + updated CL descr.

[sof, 2015-02-19 14:03:35]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-02-19 14:07:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/943483003/20001

[commit-bot: I haz the power, 2015-02-19 15:25:11]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190479