Source/modules/screen_orientation/ScreenOrientation.cpp - Issue 943483003: Gracefully handle screen.orientation access over unsupported frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 943483003: Gracefully handle screen.orientation access over unsupported frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Switch to testharness.js Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/screen_orientation/screenorientation-unsupported-no-crash.html ('k') | Source/modules/screen_orientation/ScreenOrientationController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/ScreenOrientation.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientation.cpp b/Source/modules/screen_orientation/ScreenOrientation.cpp

index f9722624331e99b722cb76c08cbe50c1dd840143..896fc9ed6be14dfe863d063544b587ce06267211 100644

--- a/Source/modules/screen_orientation/ScreenOrientation.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientation.cpp

@@ -88,6 +88,12 @@ ScreenOrientation* ScreenOrientation::create(LocalFrame* frame)

{

ASSERT(frame);

+ // Check if the ScreenOrientationController is supported for the

+ // frame. It will not be for all LocalFrames, or the frame may

+ // have been detached.

+ if (!ScreenOrientationController::from(*frame))

+ return nullptr;

ScreenOrientation* orientation = new ScreenOrientation(frame);

ASSERT(orientation->controller());

// FIXME: ideally, we would like to provide the ScreenOrientationController