Add tooltips to profile name when truncated

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index 2c8a22324cf495473a723774790156fe4271c5b1..f7a600fd529a90cc3a507a2533eda00aa08a8d66 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -701,6 +701,12 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
           IDS_PROFILES_NEW_AVATAR_MENU_EDIT_NAME_ACCESSIBLE_NAME,
           base::SysNSStringToUTF16(profileName))
                                     forAttribute:NSAccessibilityTitleAttribute];
+
+      NSSize textSize = [profileName sizeWithAttributes:
+          @{NSFontAttributeName: [profileNameTextField_ font]}];

[Avi (use Gerrit), 2015/02/27 23:14:07]

Bad code style for the literal.

http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml#Container_Lit...

[wesleylancel, 2015/02/27 23:20:40]

@AvI: needs to be 2 spaces instead of 4 then I guess?

[Avi (use Gerrit), 2015/02/27 23:22:51]

No. The literal is formatted incorrectly. The literal itself: spaces inside the
braces, and around the colon.

+
+      if (textSize.width > frameRect.size.width - [hoverImage size].width * 2)
+        [self setToolTip:profileName];
     }
 
     [[self cell] accessibilitySetOverrideValue:NSAccessibilityButtonRole
@@ -1805,6 +1811,15 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
   [profileButton setTarget:self];
   [profileButton setAction:@selector(switchToProfile:)];
 
+  NSSize textSize = [[profileButton title] sizeWithAttributes:
+      @{NSFontAttributeName: [profileButton font]}];
+
+  CGFloat availableWidth = rect.size.width - kSmallImageSide -
+      kImageTitleSpacing - kHorizontalSpacing;
+
+  if (lroundf(textSize.width) > availableWidth)

[groby-ooo-7-16, 2015/02/24 00:37:06]

Please use std::ceil instead.

[wesleylancel, 2015/02/24 08:39:31]

I actually need rounding and not ceiling here otherwise it won't work and still
show the tooltip even though the text is not truncated. Want me to replace it
with something else then?

[groby-ooo-7-16, 2015/02/27 23:02:24]

Maybe I misunderstand, but isn't ceil(width) strictly greater than
lroundf(width)? I.e
ceil: 1.0 -> 1.0, anything >1.0 and <2.0 ->2.0
round: anything >1.0 and <=1.5 ->1, >1.5 and <2.0 ->2

What am I missing?

[wesleylancel, 2015/02/27 23:20:40]

Oh! I'm sorry. I totally thought I was doing something else here. Will change.

+    [profileButton setToolTip:[profileButton title]];
+
   return profileButton.autorelease();
 }