Add tooltips to profile name when truncated

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 #import <Carbon/Carbon.h>  // kVK_Return.
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
@@ skipping 683 matching lines @@
       [profileNameTextField_ setTarget:self];
       [profileNameTextField_ setAction:@selector(saveProfileName:)];
 
       // Hide the textfield until the user clicks on the button.
       [profileNameTextField_ setHidden:YES];
 
       [[self cell] accessibilitySetOverrideValue:l10n_util::GetNSStringF(
           IDS_PROFILES_NEW_AVATAR_MENU_EDIT_NAME_ACCESSIBLE_NAME,
           base::SysNSStringToUTF16(profileName))
                                     forAttribute:NSAccessibilityTitleAttribute];
+
+      NSSize textSize = [profileName sizeWithAttributes:
+          @{NSFontAttributeName: [profileNameTextField_ font]}];

[Avi (use Gerrit), 2015/02/27 23:14:07]

Bad code style for the literal.

http://google-styleguide.googlecode.com/svn/trunk/objcguide.xml#Container_Lit...

[wesleylancel, 2015/02/27 23:20:40]

@AvI: needs to be 2 spaces instead of 4 then I guess?

[Avi (use Gerrit), 2015/02/27 23:22:51]

No. The literal is formatted incorrectly. The literal itself: spaces inside the
braces, and around the colon.

+
+      if (textSize.width > frameRect.size.width - [hoverImage size].width * 2)
+        [self setToolTip:profileName];
     }
 
     [[self cell] accessibilitySetOverrideValue:NSAccessibilityButtonRole
                                   forAttribute:NSAccessibilityRoleAttribute];
     [[self cell]
         accessibilitySetOverrideValue:NSAccessibilityRoleDescription(
                                           NSAccessibilityButtonRole, nil)
                          forAttribute:NSAccessibilityRoleDescriptionAttribute];
 
     [self setBordered:NO];
@@ skipping 1084 matching lines @@
 
   [profileButton setDefaultImage:CreateProfileImage(
       itemIcon, kSmallImageSide).ToNSImage()];
   [profileButton setImagePosition:NSImageLeft];
   [profileButton setAlignment:NSLeftTextAlignment];
   [profileButton setBordered:NO];
   [profileButton setTag:itemIndex];
   [profileButton setTarget:self];
   [profileButton setAction:@selector(switchToProfile:)];
 
+  NSSize textSize = [[profileButton title] sizeWithAttributes:
+      @{NSFontAttributeName: [profileButton font]}];
+
+  CGFloat availableWidth = rect.size.width - kSmallImageSide -
+      kImageTitleSpacing - kHorizontalSpacing;
+
+  if (lroundf(textSize.width) > availableWidth)

[groby-ooo-7-16, 2015/02/24 00:37:06]

Please use std::ceil instead.

[wesleylancel, 2015/02/24 08:39:31]

I actually need rounding and not ceiling here otherwise it won't work and still
show the tooltip even though the text is not truncated. Want me to replace it
with something else then?

[groby-ooo-7-16, 2015/02/27 23:02:24]

Maybe I misunderstand, but isn't ceil(width) strictly greater than
lroundf(width)? I.e
ceil: 1.0 -> 1.0, anything >1.0 and <2.0 ->2.0
round: anything >1.0 and <=1.5 ->1, >1.5 and <2.0 ->2

What am I missing?

[wesleylancel, 2015/02/27 23:20:40]

Oh! I'm sorry. I totally thought I was doing something else here. Will change.

+    [profileButton setToolTip:[profileButton title]];
+
   return profileButton.autorelease();
 }
 
 - (NSView*)createOptionsViewWithRect:(NSRect)rect
                          displayLock:(BOOL)displayLock {
   NSRect viewRect = NSMakeRect(0, 0,
                                rect.size.width,
                                kBlueButtonHeight + kSmallVerticalSpacing);
   base::scoped_nsobject<NSView> container([[NSView alloc] initWithFrame:rect]);
 
@@ skipping 466 matching lines @@
 }
 
 - (bool)shouldShowGoIncognito {
   bool incognitoAvailable =
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognitoAvailable && !browser_->profile()->IsGuestSession();
 }
 
 @end