Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: sky/tests/lowlevel/query-selector.sky

Issue 943433002: querySelectorAll should return List<Element> (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Named return value optimization Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tests/lowlevel/bug-438036.sky ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tests/lowlevel/query-selector.sky
diff --git a/sky/tests/lowlevel/query-selector.sky b/sky/tests/lowlevel/query-selector.sky
index 502a798fc50ccbd0298f6cf5d0ba4733598a6cf2..3bea5b8d043362be4131f1b46d47755ea4dfc465 100644
--- a/sky/tests/lowlevel/query-selector.sky
+++ b/sky/tests/lowlevel/query-selector.sky
@@ -29,9 +29,9 @@ main() {
expect(query(".class2"), isNotNull);
expect(query(".class2").classList.toString(), equals("class2"));
expect(queryAll(".class2").length, 2);
- expect(queryAll(".class2").item(0).classList.toString(), equals("class2"));
- expect(queryAll(".class2").item(1).classList.toString(), equals("class2"));
- expect(queryAll(".class2").item(0), isNot(equals(queryAll(".class2").item(1))));
+ expect(queryAll(".class2")[0].classList.toString(), equals("class2"));
+ expect(queryAll(".class2")[1].classList.toString(), equals("class2"));
+ expect(queryAll(".class2")[0], isNot(equals(queryAll(".class2")[1])));
});
test("should find elements by id", () {
@@ -40,9 +40,9 @@ main() {
expect(query("#id5").classList.toString(), equals("class5"));
// FIXME(sky): Do we still want to allow multiple id stuff like this?
expect(queryAll("#id5").length, equals(2));
- expect(queryAll("#id5").item(0), equals(query("#id5")));
- expect(queryAll("#id5").item(1), isNot(equals(query("#id5"))));
- expect(queryAll("#id5").item(1).getAttribute("id"), equals("id5"));
+ expect(queryAll("#id5")[0], equals(query("#id5")));
+ expect(queryAll("#id5")[1], isNot(equals(query("#id5"))));
+ expect(queryAll("#id5")[1].getAttribute("id"), equals("id5"));
});
test("should find elements by tag name", () {
@@ -63,21 +63,21 @@ main() {
test("should find all elements by compound selector", () {
expect(queryAll("tag-name-3.class7"), isNotNull);
expect(queryAll("tag-name-3.class7").length, equals(3));
- expect(queryAll("tag-name-3.class7").item(0).getAttribute("id"), equals("tag1"));
- expect(queryAll("tag-name-3.class7").item(1).getAttribute("id"), equals("tag2"));
+ expect(queryAll("tag-name-3.class7")[0].getAttribute("id"), equals("tag1"));
+ expect(queryAll("tag-name-3.class7")[1].getAttribute("id"), equals("tag2"));
});
test("should find all elements by attribute presence selector", () {
expect(queryAll("[testAttr]"), isNotNull);
expect(queryAll("[testAttr]").length, equals(2));
- expect(queryAll("[testAttr]").item(0).getAttribute("id"), equals("id5"));
- expect(queryAll("[testAttr]").item(1).getAttribute("id"), equals("id6"));
+ expect(queryAll("[testAttr]")[0].getAttribute("id"), equals("id5"));
+ expect(queryAll("[testAttr]")[1].getAttribute("id"), equals("id6"));
});
test("should find all elements by attribute value selector", () {
expect(queryAll("[testAttr='the value']"), isNotNull);
expect(queryAll("[testAttr='the value']").length, equals(1));
- expect(queryAll("[testAttr='the value']").item(0).getAttribute("id"), equals("id6"));
+ expect(queryAll("[testAttr='the value']")[0].getAttribute("id"), equals("id6"));
});
}
</script>
« no previous file with comments | « sky/tests/lowlevel/bug-438036.sky ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698