Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 943413003: Revert of Re-enable some HistoryApiTests (Closed)

Created:
5 years, 10 months ago by hichris123
Modified:
5 years, 10 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable some HistoryApiTests (patchset #1 id:1 of https://codereview.chromium.org/926283003/) Reason for revert: All of these tests are still flaky, so reverting it will re-disable the tests. Original issue's description: > Re-enable some HistoryApiTests > > Currently HistoryApiTest.Delete, HistoryApiTest.GetVisits, and HistoryApiTest.SearchAfterAdd are disabled. These do not flake or time out locally nor on the try bots, so this CL re-enables them. > > BUG=88318, 79074, 76170 > > Committed: https://crrev.com/f1c7ab473515bf887dcf628f9c004c3114a5f862 > Cr-Commit-Position: refs/heads/master@{#316680} TBR=rdevlin.cronin@chromium.org BUG=88318, 79074, 76170 Committed: https://crrev.com/b9a230ea5500fdaf6f8fa59d24059bdbf38ad4ec Cr-Commit-Position: refs/heads/master@{#317670}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/extensions/api/history/history_apitest.cc View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
hichris123
Created Revert of Re-enable some HistoryApiTests
5 years, 10 months ago (2015-02-23 21:18:07 UTC) #1
hichris123
I'm going to send this to the CQ. Thanks for being patient with this!
5 years, 10 months ago (2015-02-23 21:20:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943413003/1
5 years, 10 months ago (2015-02-23 21:22:03 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-23 21:22:05 UTC) #7
Devlin
On 2015/02/23 21:22:05, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 10 months ago (2015-02-23 21:23:36 UTC) #8
hichris123
On 2015/02/23 21:23:36, Devlin wrote: > On 2015/02/23 21:22:05, I haz the power (commit-bot) wrote: ...
5 years, 10 months ago (2015-02-23 21:25:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943413003/1
5 years, 10 months ago (2015-02-23 21:25:52 UTC) #11
Devlin
On 2015/02/23 21:25:32, hichris123 wrote: > On 2015/02/23 21:23:36, Devlin wrote: > > On 2015/02/23 ...
5 years, 10 months ago (2015-02-23 21:33:29 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 22:59:23 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 23:01:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9a230ea5500fdaf6f8fa59d24059bdbf38ad4ec
Cr-Commit-Position: refs/heads/master@{#317670}

Powered by Google App Engine
This is Rietveld 408576698