Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: chrome/browser/extensions/api/history/history_apitest.cc

Issue 943413003: Revert of Re-enable some HistoryApiTests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/base_switches.h" 5 #include "base/base_switches.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
(...skipping 16 matching lines...) Expand all
27 ASSERT_TRUE(StartEmbeddedTestServer()); 27 ASSERT_TRUE(StartEmbeddedTestServer());
28 ASSERT_TRUE(RunExtensionSubtest("history", "misc_search.html")) << message_; 28 ASSERT_TRUE(RunExtensionSubtest("history", "misc_search.html")) << message_;
29 } 29 }
30 30
31 // Same could happen here without the FTS (http://crbug/119505) 31 // Same could happen here without the FTS (http://crbug/119505)
32 IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_TimedSearch) { 32 IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_TimedSearch) {
33 ASSERT_TRUE(StartEmbeddedTestServer()); 33 ASSERT_TRUE(StartEmbeddedTestServer());
34 ASSERT_TRUE(RunExtensionSubtest("history", "timed_search.html")) << message_; 34 ASSERT_TRUE(RunExtensionSubtest("history", "timed_search.html")) << message_;
35 } 35 }
36 36
37 IN_PROC_BROWSER_TEST_F(HistoryApiTest, Delete) { 37 #if defined(OS_WIN)
38 // Flaky on Windows: crbug.com/88318
39 #define MAYBE_Delete DISABLED_Delete
40 #else
41 #define MAYBE_Delete Delete
42 #endif
43 IN_PROC_BROWSER_TEST_F(HistoryApiTest, MAYBE_Delete) {
38 ASSERT_TRUE(StartEmbeddedTestServer()); 44 ASSERT_TRUE(StartEmbeddedTestServer());
39 ASSERT_TRUE(RunExtensionSubtest("history", "delete.html")) << message_; 45 ASSERT_TRUE(RunExtensionSubtest("history", "delete.html")) << message_;
40 } 46 }
41 47
42 IN_PROC_BROWSER_TEST_F(HistoryApiTest, DeleteProhibited) { 48 IN_PROC_BROWSER_TEST_F(HistoryApiTest, DeleteProhibited) {
43 browser()->profile()->GetPrefs()-> 49 browser()->profile()->GetPrefs()->
44 SetBoolean(prefs::kAllowDeletingBrowserHistory, false); 50 SetBoolean(prefs::kAllowDeletingBrowserHistory, false);
45 ASSERT_TRUE(StartEmbeddedTestServer()); 51 ASSERT_TRUE(StartEmbeddedTestServer());
46 ASSERT_TRUE(RunExtensionSubtest("history", "delete_prohibited.html")) << 52 ASSERT_TRUE(RunExtensionSubtest("history", "delete_prohibited.html")) <<
47 message_; 53 message_;
48 } 54 }
49 55
50 IN_PROC_BROWSER_TEST_F(HistoryApiTest, GetVisits) { 56 // See crbug.com/79074
57 IN_PROC_BROWSER_TEST_F(HistoryApiTest, DISABLED_GetVisits) {
51 ASSERT_TRUE(StartEmbeddedTestServer()); 58 ASSERT_TRUE(StartEmbeddedTestServer());
52 ASSERT_TRUE(RunExtensionSubtest("history", "get_visits.html")) << message_; 59 ASSERT_TRUE(RunExtensionSubtest("history", "get_visits.html")) << message_;
53 } 60 }
54 61
55 IN_PROC_BROWSER_TEST_F(HistoryApiTest, SearchAfterAdd) { 62 #if defined(OS_WIN)
63 // Searching for a URL right after adding it fails on win XP.
64 // Fix this as part of crbug/76170.
65 #define MAYBE_SearchAfterAdd DISABLED_SearchAfterAdd
66 #else
67 #define MAYBE_SearchAfterAdd SearchAfterAdd
68 #endif
69
70 IN_PROC_BROWSER_TEST_F(HistoryApiTest, MAYBE_SearchAfterAdd) {
56 ASSERT_TRUE(StartEmbeddedTestServer()); 71 ASSERT_TRUE(StartEmbeddedTestServer());
57 ASSERT_TRUE(RunExtensionSubtest("history", "search_after_add.html")) 72 ASSERT_TRUE(RunExtensionSubtest("history", "search_after_add.html"))
58 << message_; 73 << message_;
59 } 74 }
60 75
61 } // namespace extensions 76 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698