bindings: [Replaceable] must not be specified with [PutForwards].

bindings: [Replaceable] must not be specified with [PutForwards].

Simply removes [Replaceable] extended attribute at Window.location.

https://heycam.github.io/webidl/#Replaceable says
"An attribute with the [Replaceable] extended attribute must not
also be declared with the [PutForwards] extended attribute."

https://html.spec.whatwg.org/multipage/browsers.html#window says
[PutForwards=href, Unforgeable] readonly attribute Location location;

Thus, this CL removes [Replaceable] extended attribute.

There is no change in generated code.

Note that Document.idl has correctly been specifying
[PutForwards=href, Unforgeable] readonly attribute Location location;
With this CL, Window.idl specifies the same.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190645

[Yuki, 2015-02-23 07:58:13]

yukishiino@chromium.org changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[Yuki, 2015-02-23 07:58:14]

Could you guys review this CL?

We may want to add checks of validity of IDLs.  Not only [Replaceable] +
[PutForwards], but also other combinations.  e.g. [PutForwards] must always be
used with "readonly".

[haraken, 2015-02-23 08:03:01]

> The access control (in generated code) changes
> from: v8::ALL_CAN_READ | v8::ALL_CAN_WRITE | v8::PROHIBITS_OVERWRITING
>   to: v8::ALL_CAN_READ | v8::PROHIBITS_OVERWRITING
> There is no other change in generated code.

What does this change imply from the perspective of JS behavior?

Does this perhaps change Object.getOwnPropertyDescriptor(window,
"location").writable?

[Yuki, 2015-02-23 08:38:10]

On 2015/02/23 08:03:01, haraken wrote:
> > The access control (in generated code) changes
> > from: v8::ALL_CAN_READ | v8::ALL_CAN_WRITE | v8::PROHIBITS_OVERWRITING
> >   to: v8::ALL_CAN_READ | v8::PROHIBITS_OVERWRITING
> > There is no other change in generated code.
> 
> What does this change imply from the perspective of JS behavior?
> 
> Does this perhaps change Object.getOwnPropertyDescriptor(window,
> "location").writable?

As far as I can see, there is no behavioral changes.
The property descriptor seems the same.  writable is true regardless of whether
the change is applied or not.

window.location = "http://example.org/"
works with / without the change.

According to the comment in v8.h, v8::ALL_CAN_WRITE allows cross-context access.

Let me dig a little bit more.  It seems we need this flag.

[haraken, 2015-02-23 08:44:08]

haraken@chromium.org changed reviewers:
+ dcarney@chromium.org, jochen@chromium.org

[haraken, 2015-02-23 08:44:09]

+jochen, +dcarney, who should know the V8 flags better :)

[Jens Widell, 2015-02-23 08:44:36]

On 2015/02/23 08:38:10, Yuki wrote:
> On 2015/02/23 08:03:01, haraken wrote:
> > > The access control (in generated code) changes
> > > from: v8::ALL_CAN_READ | v8::ALL_CAN_WRITE | v8::PROHIBITS_OVERWRITING
> > >   to: v8::ALL_CAN_READ | v8::PROHIBITS_OVERWRITING
> > > There is no other change in generated code.
> > 
> > What does this change imply from the perspective of JS behavior?
> > 
> > Does this perhaps change Object.getOwnPropertyDescriptor(window,
> > "location").writable?
> 
> As far as I can see, there is no behavioral changes.
> The property descriptor seems the same.  writable is true regardless of
whether
> the change is applied or not.
> 
> window.location = "http://example.org/"
> works with / without the change.
> 
> According to the comment in v8.h, v8::ALL_CAN_WRITE allows cross-context
access.
> 
> Let me dig a little bit more.  It seems we need this flag.

Maybe the appropriate thing is to make PutForwards, like Replaceable, generate
an v8::ALL_CAN_WRITE in access_control_list() [in v8_attributes.py] for
attributes with [DoNotCheckSecurity]?

[Yuki, 2015-02-23 08:54:01]

On 2015/02/23 08:44:36, Jens Widell wrote:
> On 2015/02/23 08:38:10, Yuki wrote:
> > On 2015/02/23 08:03:01, haraken wrote:
> > > > The access control (in generated code) changes
> > > > from: v8::ALL_CAN_READ | v8::ALL_CAN_WRITE | v8::PROHIBITS_OVERWRITING
> > > >   to: v8::ALL_CAN_READ | v8::PROHIBITS_OVERWRITING
> > > > There is no other change in generated code.
> > > 
> > > What does this change imply from the perspective of JS behavior?
> > > 
> > > Does this perhaps change Object.getOwnPropertyDescriptor(window,
> > > "location").writable?
> > 
> > As far as I can see, there is no behavioral changes.
> > The property descriptor seems the same.  writable is true regardless of
> whether
> > the change is applied or not.
> > 
> > window.location = "http://example.org/"
> > works with / without the change.
> > 
> > According to the comment in v8.h, v8::ALL_CAN_WRITE allows cross-context
> access.
> > 
> > Let me dig a little bit more.  It seems we need this flag.
> 
> Maybe the appropriate thing is to make PutForwards, like Replaceable, generate
> an v8::ALL_CAN_WRITE in access_control_list() [in v8_attributes.py] for
> attributes with [DoNotCheckSecurity]?

Agreed.  Updated v8_attributes.py.

Could you guys take another look?

[haraken, 2015-02-23 08:58:59]

LGTM!

[Jens Widell, 2015-02-23 09:01:33]

jl@opera.com changed reviewers:
+ jl@opera.com

[Jens Widell, 2015-02-23 09:01:34]

LGTM

[Yuki, 2015-02-23 10:39:11]

The CQ bit was checked by yukishiino@chromium.org

[commit-bot: I haz the power, 2015-02-23 10:39:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/943313002/20001

[commit-bot: I haz the power, 2015-02-23 10:43:20]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190645