Source/bindings/scripts/v8_attributes.py - Issue 943313002: bindings: [Replaceable] must not be specified with [PutForwards].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 943313002: bindings: [Replaceable] must not be specified with [PutForwards]. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed review comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 8899902608cd2b6b21f6e1d73f80c3ef515bfc12..8e3baff3c820a7a4f3d162c5947cb757d1e325bd 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -454,6 +454,7 @@ def access_control_list(interface, attribute):

else:

access_control.append('v8::ALL_CAN_READ')

if (not attribute.is_read_only or

+ 'PutForwards' in extended_attributes or

'Replaceable' in extended_attributes):

access_control.append('v8::ALL_CAN_WRITE')

if is_unforgeable(interface, attribute):

« no previous file with comments | « no previous file | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »