Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1230)

Unified Diff: sky/engine/web/WebElement.cpp

Issue 943013002: Implement Custom Elements (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: attributeChanged***d***Callback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/web/WebElement.cpp
diff --git a/sky/engine/web/WebElement.cpp b/sky/engine/web/WebElement.cpp
index 86751d191a3bc181dc0b2fd944e3a8cc001dbc52..5bae7092588c74840949697afff6b8e766d5666e 100644
--- a/sky/engine/web/WebElement.cpp
+++ b/sky/engine/web/WebElement.cpp
@@ -33,7 +33,7 @@
#include "sky/engine/bindings/exception_state.h"
#include "sky/engine/core/dom/Element.h"
-#include "sky/engine/core/dom/custom/CustomElementProcessingStack.h"
+#include "sky/engine/core/dom/custom2/new_custom_element_callback_scope.h"
#include "sky/engine/core/dom/shadow/ShadowRoot.h"
#include "sky/engine/core/rendering/RenderBoxModelObject.h"
#include "sky/engine/core/rendering/RenderObject.h"
@@ -57,7 +57,7 @@ void WebElement::removeAttribute(const WebString& attrName)
{
// TODO: Custom element callbacks need to be called on WebKit API methods that
// mutate the DOM in any way.
- CustomElementProcessingStack::CallbackDeliveryScope deliverCustomElementCallbacks;
+ NewCustomElementCallbackScope deliveryScope;
unwrap<Element>()->removeAttribute(attrName);
}
@@ -70,7 +70,7 @@ bool WebElement::setAttribute(const WebString& attrName, const WebString& attrVa
{
// TODO: Custom element callbacks need to be called on WebKit API methods that
// mutate the DOM in any way.
- CustomElementProcessingStack::CallbackDeliveryScope deliverCustomElementCallbacks;
+ NewCustomElementCallbackScope deliveryScope;
TrackExceptionState exceptionState;
unwrap<Element>()->setAttribute(attrName, attrValue, exceptionState);
return !exceptionState.had_exception();

Powered by Google App Engine
This is Rietveld 408576698