sky/engine/core/html/imports/HTMLImportLoader.cpp - Issue 943013002: Implement Custom Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/html/imports/HTMLImportLoader.cpp

Issue 943013002: Implement Custom Elements (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: attributeChanged***d***Callback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/html/imports/HTMLImportLoader.cpp

diff --git a/sky/engine/core/html/imports/HTMLImportLoader.cpp b/sky/engine/core/html/imports/HTMLImportLoader.cpp

index 5dfd5e40b5f92d28edbaaf63fdc383d4b22a8f10..b3b6efbff0d3c8b16702134a4627892a51b01038 100644

--- a/sky/engine/core/html/imports/HTMLImportLoader.cpp

+++ b/sky/engine/core/html/imports/HTMLImportLoader.cpp

@@ -100,7 +100,7 @@ HTMLImportLoader::State HTMLImportLoader::startWritingAndParsing(mojo::URLRespon

ASSERT(contextDocument.get());

KURL url(ParsedURLString, String::fromUTF8(response->url));

DocumentInit init = DocumentInit(url, 0, contextDocument, m_controller)

- .withRegistrationContext(m_controller->master()->registrationContext());

+ .withElementRegistry(m_controller->master()->elementRegistry());

m_document = Document::create(init);

m_module = Module::create(contextDocument.get(), nullptr, m_document.get(), url.string());

m_document->startParsing()->parse(response->body.Pass(), base::Bind(base::DoNothing));