sky/engine/bindings/scripts/v8_methods.py - Issue 943013002: Implement Custom Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/v8_methods.py

Issue 943013002: Implement Custom Elements (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: attributeChanged***d***Callback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/v8_methods.py

diff --git a/sky/engine/bindings/scripts/v8_methods.py b/sky/engine/bindings/scripts/v8_methods.py

index 4e204de0968bd25009c4be3e7783acc3fcb03da6..68f0195ef88a1f49ce29972766cff71e428526fd 100644

--- a/sky/engine/bindings/scripts/v8_methods.py

+++ b/sky/engine/bindings/scripts/v8_methods.py

@@ -101,7 +101,7 @@ def method_context(interface, method):

includes.add('bindings/core/v8/ScriptState.h')

is_custom_element_callbacks = 'CustomElementCallbacks' in extended_attributes

if is_custom_element_callbacks:

- includes.add('core/dom/custom/CustomElementProcessingStack.h')

+ includes.add('sky/engine/core/dom/custom2/new_custom_element_callback_scope.h')

is_raises_exception = 'RaisesException' in extended_attributes