sky/engine/bindings/scripts/v8_attributes.py - Issue 943013002: Implement Custom Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/v8_attributes.py

Issue 943013002: Implement Custom Elements (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: attributeChanged***d***Callback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/v8_attributes.py

diff --git a/sky/engine/bindings/scripts/v8_attributes.py b/sky/engine/bindings/scripts/v8_attributes.py

index ab4042ec602b608fb940de0d61467af153e66a4f..efb61560af5d82036d553af619cbfc32988f1445 100644

--- a/sky/engine/bindings/scripts/v8_attributes.py

+++ b/sky/engine/bindings/scripts/v8_attributes.py

@@ -54,7 +54,7 @@ def attribute_context(interface, attribute):

is_custom_element_callbacks = 'CustomElementCallbacks' in extended_attributes

is_reflect = 'Reflect' in extended_attributes

if is_custom_element_callbacks or is_reflect:

- includes.add('core/dom/custom/CustomElementProcessingStack.h')

+ includes.add('sky/engine/core/dom/custom2/new_custom_element_callback_scope.h')

# [TypeChecking]

has_type_checking_unrestricted = (

(has_extended_attribute_value(interface, 'TypeChecking', 'Unrestricted') or