Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 942963003: Cleanup: Fix content header include guards. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, je_julie(Not used), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, ben+mojo_chromium.org, mkwst+moarreviews-shell_chromium.org, jsbell+serviceworker_chromium.org, mlamouri+watch-geolocation_chromium.org, aboxhall+watch_chromium.org, jdduke+watch_chromium.org, tzik, jam, abarth-chromium, jbauman+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, extensions-reviews_chromium.org, rickyz+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, nhiroki, Michael van Ouwerkerk, piman+watch_chromium.org, dcheng, danakj+watch_chromium.org, jochen+watch_chromium.org, michaeln, chromium-apps-reviews_chromium.org, plundblad+watch_chromium.org, wfh+watch_chromium.org, serviceworker-reviews, nektar+watch_chromium.org, mcasas+watch_chromium.org, yurys, Aaron Boodman, kinuko+serviceworker, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, darin (slow to review), wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Fix content header include guards. The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=435361 TEST=content_unittests R=avi@chromium.org TBR=avi@chromium.org Committed: https://crrev.com/bccc34c7258f93a5d5c8572964a318c1086a4528 Cr-Commit-Position: refs/heads/master@{#318520}

Patch Set 1 #

Total comments: 6

Patch Set 2 : revert wrong changes made by the script #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+468 lines, -468 lines) Patch
M content/app/mojo/mojo_init.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/browser_startup_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/content_view_statics.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/gesture_event_type.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_external_begin_frame_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/overscroll_glow.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/appcache_url_request_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/buffer_queue.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/compositor/test/no_transport_image_transport_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/forwarding_agent_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/devtools/protocol/usage_and_quota_query.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/dom_storage/dom_storage_task_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/file_descriptor_info_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/blob_storage_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/mock_file_change_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/mock_file_update_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/mock_url_request_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gamepad/gamepad_consumer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gamepad/gamepad_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/location_arbitrator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/location_provider_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/mock_location_arbitrator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_internals_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/global_routing_id.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_message_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/manifest/manifest_manager_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/message_port_message_filter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notification_service_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/power_usage_monitor_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/input_ack_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mock_input_ack_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/stylus_text_selector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_action_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_capture_devices_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/content_browser_pepper_host_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_file_io_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/webmenurunner_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/safe_util_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_delegate_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/screen_orientation/screen_orientation_dispatcher_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_database_task_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/shared_worker/worker_storage_partition.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/signed_certificate_timestamp_store_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/storage_partition_impl_map.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tracing/etw_system_event_consumer_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tracing/tracing_ui.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/aura/shadow_layer_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/generic_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_histogram_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/child_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/npapi/npobject_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_stream_url.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_string_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/power_monitor_broadcast_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/push_messaging/push_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/threaded_data_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/web_url_request_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/webblobregistry_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/worker_task_runner.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/address_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/android/address_parser_internal.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/appcache_interfaces.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_constants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/frame_message_enums.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/frame_replication_state.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gamepad_param_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_tracking.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_uma_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_calayer_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_fbo_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/image_transport_surface_iosurface_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/accelerated_video_decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/media/v4l2_device.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_image_processor.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/x_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/gesture_event_stream_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/input_event_stream_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/input/synthetic_tap_gesture_params.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/input/touch_event_stream_validator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/mac/font_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_client_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/common/view_message_enums.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/android/content_view_layer_renderer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/android/devtools_auth.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/readback_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/render_widget_host_view_frame_subscriber.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/screen_orientation_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/screen_orientation_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/tracing_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/worker_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/child/child_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/child/image_decoder_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/child_process_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/dwrite_font_platform_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/favicon_url.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/geoposition.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/injection_test_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/manifest.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/resource_devtools_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/renderer/platform_event_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/renderer_gamepad_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/webrtc_log_message_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/browser_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/download_test_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/fake_speech_recognition_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_download_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_notification_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/mock_special_storage_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/nested_message_pump_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_content_client_initializer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/clipboard_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/fetchers/manifest_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/fetchers/web_url_loader_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/queue_message_swap_promise.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/ime_event_guard.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/input/input_handler_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/manifest/manifest_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/manifest/manifest_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/manifest/manifest_uma_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_constraint_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/peer_connection_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/video_destination_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_logging.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/net_info_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/fullscreen_container.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/host_array_buffer_var.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/host_resource_var.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_compositor_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/renderer_restrict_dispatch_group.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/resource_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/url_request_info_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/v8_var_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/scheduler/renderer_task_queue_selector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/screen_orientation/screen_orientation_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/skia_benchmarking_extension.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/webscrollbarbehavior_impl_gtkoraura.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/webscrollbarbehavior_impl_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/ipc_echo_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_creator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/binding_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/ipc_echo.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/gc_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_frame_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_process_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/leak_detector.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/layout_test/webkit_test_runner.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/shell_render_view_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_constraints.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_screen_orientation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_data_channel_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_dtmf_sender_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_runner.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/fileapi_test_file_set.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/mock_google_streaming_server.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/mock_webblob_registry_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url2_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_javascript_open_popup.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_new_fails_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_schedule_timer_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_test_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_windowed_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_windowless_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/zygote/zygote_linux.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tfarina
5 years, 10 months ago (2015-02-25 20:03:00 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/942963003/diff/1/content/common/clipboard_messages.h File content/common/clipboard_messages.h (right): https://codereview.chromium.org/942963003/diff/1/content/common/clipboard_messages.h#newcode103 content/common/clipboard_messages.h:103: #endif // CONTENT_COMMON_CLIPBOARD_MESSAGES_H_ // defined(OS_MACOSX) (and, as this file ...
5 years, 10 months ago (2015-02-25 20:28:30 UTC) #2
tfarina
https://codereview.chromium.org/942963003/diff/1/content/common/clipboard_messages.h File content/common/clipboard_messages.h (right): https://codereview.chromium.org/942963003/diff/1/content/common/clipboard_messages.h#newcode103 content/common/clipboard_messages.h:103: #endif // CONTENT_COMMON_CLIPBOARD_MESSAGES_H_ On 2015/02/25 20:28:30, Avi wrote: > ...
5 years, 10 months ago (2015-02-25 20:35:30 UTC) #3
Avi (use Gerrit)
LGTM
5 years, 10 months ago (2015-02-25 20:57:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942963003/20001
5 years, 9 months ago (2015-02-27 19:29:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/63008)
5 years, 9 months ago (2015-02-27 19:38:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942963003/40001
5 years, 9 months ago (2015-02-27 19:51:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/46218)
5 years, 9 months ago (2015-02-27 20:23:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942963003/40001
5 years, 9 months ago (2015-02-27 21:26:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-02-27 21:32:43 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 21:33:33 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bccc34c7258f93a5d5c8572964a318c1086a4528
Cr-Commit-Position: refs/heads/master@{#318520}

Powered by Google App Engine
This is Rietveld 408576698