Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 942963002: Need to invalidate scrollbars in case they get repositioned. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Need to invalidate scrollbars in case they get repositioned. If the owning renderer gets resized, the scrollbar may be repositioned. Don't rely on other reasons for invalidation (background, borders, child content getting relaid out, etc.) to accidentally get the area covered by the scrollbars invalidated, since there may very well be no other reason. BUG=460434 R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190681

Patch Set 1 #

Total comments: 4

Patch Set 2 : code review #

Patch Set 3 : code review - override final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -2 lines) Patch
A LayoutTests/fast/repaint/horizontal-scrollbar-grow-container-height.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/horizontal-scrollbar-grow-container-height-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/horizontal-scrollbar-shrink-container-height.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/horizontal-scrollbar-shrink-container-height-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/resources/display-then-call.js View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/vertical-scrollbar-grow-container-width.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/vertical-scrollbar-grow-container-width-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/vertical-scrollbar-shrink-container-width.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/repaint/vertical-scrollbar-shrink-container-width-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-21 13:54:24 UTC) #1
dsinclair
https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp File Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp#newcode639 Source/core/layout/LayoutObject.cpp:639: return rendererHasNoBoxEffect() && !hasNonCompositedScrollbars(); Can we pull this out ...
5 years, 10 months ago (2015-02-23 15:13:53 UTC) #3
mstensho (USE GERRIT)
https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp File Source/core/layout/LayoutObject.cpp (right): https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp#newcode639 Source/core/layout/LayoutObject.cpp:639: return rendererHasNoBoxEffect() && !hasNonCompositedScrollbars(); On 2015/02/23 15:13:53, dsinclair wrote: ...
5 years, 10 months ago (2015-02-23 17:22:38 UTC) #4
dsinclair
On 2015/02/23 at 17:22:38, mstensho wrote: > https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp > File Source/core/layout/LayoutObject.cpp (right): > > https://codereview.chromium.org/942963002/diff/1/Source/core/layout/LayoutObject.cpp#newcode639 ...
5 years, 10 months ago (2015-02-23 17:35:29 UTC) #5
mstensho (USE GERRIT)
On 2015/02/23 17:35:29, dsinclair wrote: > On 2015/02/23 at 17:22:38, mstensho wrote: > > > ...
5 years, 10 months ago (2015-02-23 17:52:13 UTC) #6
dsinclair
lgtm
5 years, 10 months ago (2015-02-23 17:55:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942963002/40001
5 years, 10 months ago (2015-02-23 17:56:23 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:39:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190681

Powered by Google App Engine
This is Rietveld 408576698