Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934163004: Modernize coding style in core/html/forms/. (Closed)

Created:
5 years, 10 months ago by tkent
Modified:
5 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Modernize coding style in core/html/forms/. - |using| instead of |typedef| - Needs only one of |override|, |final|, or |virtual|. - nullptr - #include order BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190522

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -426 lines) Patch
M Source/core/html/forms/BaseButtonInputType.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/forms/BaseCheckableInputType.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/forms/BaseChooserOnlyDateAndTimeInputType.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/html/forms/BaseClickableWithKeyInputType.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/forms/BaseDateAndTimeInputType.h View 1 chunk +19 lines, -19 lines 0 comments Download
M Source/core/html/forms/BaseDateAndTimeInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 1 chunk +46 lines, -46 lines 0 comments Download
M Source/core/html/forms/BaseTextInputType.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/forms/ButtonInputType.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/CheckboxInputType.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/html/forms/ColorInputType.h View 1 1 chunk +21 lines, -21 lines 0 comments Download
M Source/core/html/forms/ColorInputType.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/DateInputType.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/forms/DateTimeLocalInputType.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/html/forms/EmailInputType.h View 1 chunk +11 lines, -10 lines 0 comments Download
M Source/core/html/forms/FileInputType.h View 1 1 chunk +21 lines, -22 lines 0 comments Download
M Source/core/html/forms/FormController.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/FormController.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/HiddenInputType.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/html/forms/ImageInputType.h View 1 chunk +23 lines, -23 lines 0 comments Download
M Source/core/html/forms/InputType.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputTypeView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/MonthInputType.h View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/html/forms/NumberInputType.h View 1 chunk +26 lines, -26 lines 0 comments Download
M Source/core/html/forms/PasswordInputType.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/forms/RadioButtonGroupScope.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/RadioInputType.h View 1 chunk +12 lines, -11 lines 0 comments Download
M Source/core/html/forms/RangeInputType.h View 1 chunk +26 lines, -25 lines 0 comments Download
M Source/core/html/forms/RangeInputType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/ResetInputType.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/forms/SearchInputType.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/html/forms/SearchInputType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/SubmitInputType.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/html/forms/TelephoneInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.h View 1 2 chunks +35 lines, -35 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextInputType.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/forms/TimeInputType.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/html/forms/TypeAhead.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/URLInputType.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/html/forms/WeekInputType.h View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Please review this.
5 years, 10 months ago (2015-02-18 09:25:46 UTC) #3
keishi
lgtm
5 years, 10 months ago (2015-02-20 02:01:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934163004/40001
5 years, 10 months ago (2015-02-20 02:33:51 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 03:15:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190522

Powered by Google App Engine
This is Rietveld 408576698