ChannelMojo should use PID from the bootstrap Channel.

ChannelMojo should use PID from the bootstrap Channel.

The original naive implementation ignores sandboxing limitation.
It should ask underlying channel to do it correctly.

TEST=IPCChannelMojoTest.VerifyGlobalPid
R=agl@chromium.org, viettrungluu@chromium.org
BUG=451553
Committed: https://crrev.com/0bd20bd071b18f094999263b377ee58173347567
Cr-Commit-Position: refs/heads/master@{#318099}

[agl, 2015-02-25 02:45:29]

lgtm

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
File ipc/mojo/ipc_channel_mojo_unittest.cc (right):

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:588: ListenerThatVerifiesPeerPid() {}
Won't the compiler synthesise the empty constructor for you?

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:600: 
remove blank line.

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:630: #endif
"  // OS_LINUX" at the end of the line.

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_mojo_bootstrap.h
File ipc/mojo/ipc_mojo_bootstrap.h (right):

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_mojo_bootstrap....
ipc/mojo/ipc_mojo_bootstrap.h:49: // Ask its own process ID to |channel_|.
This is wrong, but I'm not sure what it should be. Perhaps:

// GetSelfPID returns the PID associated with |channel_|.

[Hajime Morrita, 2015-02-25 19:13:06]

Thanks for the review! Landing...

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
File ipc/mojo/ipc_channel_mojo_unittest.cc (right):

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:588: ListenerThatVerifiesPeerPid() {}
On 2015/02/25 02:45:29, agl wrote:
> Won't the compiler synthesise the empty constructor for you?
It should. removed.

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:600: 
On 2015/02/25 02:45:29, agl wrote:
> remove blank line.

Done.

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_channel_mojo_un...
ipc/mojo/ipc_channel_mojo_unittest.cc:630: #endif
On 2015/02/25 02:45:29, agl wrote:
> "  // OS_LINUX" at the end of the line.

Done.

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_mojo_bootstrap.h
File ipc/mojo/ipc_mojo_bootstrap.h (right):

https://codereview.chromium.org/942933005/diff/1/ipc/mojo/ipc_mojo_bootstrap....
ipc/mojo/ipc_mojo_bootstrap.h:49: // Ask its own process ID to |channel_|.
On 2015/02/25 02:45:29, agl wrote:
> This is wrong, but I'm not sure what it should be. Perhaps:
> 
> // GetSelfPID returns the PID associated with |channel_|.

Done.

[Hajime Morrita, 2015-02-25 19:13:10]

The CQ bit was checked by morrita@chromium.org

[Hajime Morrita, 2015-02-25 19:13:10]

The patchset sent to the CQ was uploaded after l-g-t-m from agl@chromium.org
Link to the patchset: https://codereview.chromium.org/942933005/#ps20001 (title:
"Landing")

[commit-bot: I haz the power, 2015-02-25 19:13:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/942933005/20001

[commit-bot: I haz the power, 2015-02-25 20:11:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-25 20:12:36]

Patchset 2 (id:??) landed as
https://crrev.com/0bd20bd071b18f094999263b377ee58173347567
Cr-Commit-Position: refs/heads/master@{#318099}