ChannelMojo should use PID from the bootstrap Channel.

ipc/mojo/ipc_channel_mojo_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/mojo/ipc_channel_mojo.h"
 
 #include "base/base_paths.h"
 #include "base/files/file.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/pickle.h"
+#include "base/test/test_timeouts.h"
 #include "base/threading/thread.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_test_base.h"
 #include "ipc/ipc_test_channel_listener.h"
 #include "ipc/mojo/ipc_channel_mojo_host.h"
 #include "ipc/mojo/ipc_mojo_handle_attachment.h"
 #include "ipc/mojo/ipc_mojo_message_helper.h"
 
 #if defined(OS_POSIX)
 #include "base/file_descriptor_posix.h"
@@ skipping 549 matching lines @@
   client.Connect();
   listener.set_sender(client.channel());
 
   base::MessageLoop::current()->Run();
 
   return 0;
 }
 
 #endif
 
+#if defined(OS_LINUX)
+
+const base::ProcessId kMagicChildId = 54321;
+
+class ListenerThatVerifiesPeerPid : public IPC::Listener {
+ public:
+  ListenerThatVerifiesPeerPid() {}

[agl, 2015/02/25 02:45:29]

Won't the compiler synthesise the empty constructor for you?

[Hajime Morrita, 2015/02/25 19:13:06]

It should. removed.

+  ~ListenerThatVerifiesPeerPid() override {}
+
+  void OnChannelConnected(int32 peer_pid) override {
+    EXPECT_EQ(peer_pid, kMagicChildId);
+    base::MessageLoop::current()->Quit();
+  }
+
+  bool OnMessageReceived(const IPC::Message& message) override {
+    NOTREACHED();
+    return true;
+  }
+

[agl, 2015/02/25 02:45:29]

remove blank line.

[Hajime Morrita, 2015/02/25 19:13:05]

Done.

+};
+
+TEST_F(IPCChannelMojoTest, VerifyGlobalPid) {
+  Init("IPCChannelMojoTestVerifyGlobalPidClient");
+
+  ListenerThatVerifiesPeerPid listener;
+  CreateChannel(&listener);
+  ASSERT_TRUE(ConnectChannel());
+  ASSERT_TRUE(StartClient());
+
+  base::MessageLoop::current()->Run();
+  this->channel()->Close();
+
+  EXPECT_TRUE(WaitForClientShutdown());
+  DestroyChannel();
+}
+
+MULTIPROCESS_IPC_TEST_CLIENT_MAIN(IPCChannelMojoTestVerifyGlobalPidClient) {
+  IPC::Channel::SetGlobalPid(kMagicChildId);
+  ListenerThatQuits listener;
+  ChannelClient client(&listener,
+                       "IPCChannelMojoTestVerifyGlobalPidClient");
+  client.Connect();
+
+  base::MessageLoop::current()->Run();
+
+  return 0;
+}
+
+#endif

[agl, 2015/02/25 02:45:29]

"  // OS_LINUX" at the end of the line.

[Hajime Morrita, 2015/02/25 19:13:06]

Done.

+
 }  // namespace