Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 942933002: Fix cannot disconnect remoting session. (Closed)

Created:
5 years, 10 months ago by kelvinp
Modified:
5 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cannot disconnect remoting session. Cause: remoting.clientSession.disconnect() accidentally removed in https://codereview.chromium.org/814133007 Fix: Call remoting.clientSession.disconnect(), this will cause a client state change and invoke onClientStateChange_ BUG=460324 Committed: https://crrev.com/9eee8443d6546cfad753f22cb2f94a7c5aa948b5 Cr-Commit-Position: refs/heads/master@{#317394}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M remoting/webapp/crd/js/client_screen.js View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kelvinp
PTAL
5 years, 10 months ago (2015-02-20 18:54:52 UTC) #3
garykac
lgtm
5 years, 10 months ago (2015-02-20 19:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942933002/20001
5 years, 10 months ago (2015-02-20 19:53:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-20 20:43:42 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:44:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9eee8443d6546cfad753f22cb2f94a7c5aa948b5
Cr-Commit-Position: refs/heads/master@{#317394}

Powered by Google App Engine
This is Rietveld 408576698