Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 814133007: [Chromoting] Re-add call to chrome.app.window.current().close() (Closed)

Created:
5 years, 11 months ago by garykac
Modified:
5 years, 11 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Re-add call to chrome.app.window.current().close() A recent change removed a call to close the app window because it seemed redundant with the call in disconnect(), but that code path is not called when the host initiates the disconnection. This reverts the calling pattern to what it was before the aforementioned change. NOTRY=True BUG= Committed: https://crrev.com/0805b9c8b55ddf3e26f83d09e9bfc2cf5ba0b9f4 Cr-Commit-Position: refs/heads/master@{#312278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/webapp/crd/js/client_screen.js View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/webapp/crd/js/client_session.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 11 months ago (2015-01-17 00:44:34 UTC) #2
Jamie
lgtm
5 years, 11 months ago (2015-01-17 00:54:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/814133007/1
5 years, 11 months ago (2015-01-20 21:40:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 21:41:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:42:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0805b9c8b55ddf3e26f83d09e9bfc2cf5ba0b9f4
Cr-Commit-Position: refs/heads/master@{#312278}

Powered by Google App Engine
This is Rietveld 408576698