Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: storage/browser/blob/blob_data_builder.cc

Issue 942633004: IndexedDB: Fixed support for empty blobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added back in some DCHECKs and simplified empty file write. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/blob/blob_data_builder.cc
diff --git a/storage/browser/blob/blob_data_builder.cc b/storage/browser/blob/blob_data_builder.cc
index 51946c882f4e8dfec78e38fdfe4966c771695d7e..099a8962dd449d2f1ba120656fdf238dde43f50e 100644
--- a/storage/browser/blob/blob_data_builder.cc
+++ b/storage/browser/blob/blob_data_builder.cc
@@ -25,7 +25,6 @@ void BlobDataBuilder::AppendFile(const base::FilePath& file_path,
uint64_t offset,
uint64_t length,
const base::Time& expected_modification_time) {
- DCHECK(length > 0);
michaeln 2015/02/25 20:35:43 Out of curiosity, if (!length) return goes here in
cmumford 2015/02/25 22:37:29 Yes, the tests do pass. Does that give you enough
michaeln 2015/02/26 02:05:37 A little uncomfortable without a better understand
scoped_ptr<DataElement> element(new DataElement());
element->SetToFilePathRange(file_path, offset, length,
expected_modification_time);
« no previous file with comments | « no previous file | storage/browser/blob/blob_storage_context.cc » ('j') | storage/browser/blob/blob_storage_context.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698