storage/browser/blob/blob_storage_context.cc - Issue 942633004: IndexedDB: Fixed support for empty blobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/blob/blob_storage_context.cc

Issue 942633004: IndexedDB: Fixed support for empty blobs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added back in some DCHECKs and simplified empty file write. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/blob/blob_storage_context.cc

diff --git a/storage/browser/blob/blob_storage_context.cc b/storage/browser/blob/blob_storage_context.cc

index 5170ceb37e5d209375c4426dd08c8989a233db9c..6231aaa23e98b6b017a3d5c643f0a9c2fb25db30 100644

--- a/storage/browser/blob/blob_storage_context.cc

+++ b/storage/browser/blob/blob_storage_context.cc

@@ -309,7 +309,6 @@ bool BlobStorageContext::AppendAllocatedBlobItem(

const DataElement& data_element = blob_item->data_element();

uint64 length = data_element.length();

uint64 offset = data_element.offset();

- DCHECK_GT(length, 0u);

michaeln 2015/02/26 02:50:33 I think BlobURLRequestJob is relying on items have

UMA_HISTOGRAM_COUNTS("Storage.Blob.StorageSizeBeforeAppend",

memory_usage_ / 1024);

switch (data_element.type()) {