Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 942633002: Switch AppBannerManager on use of Unretained to use it's weakptr factory. (Closed)

Created:
5 years, 10 months ago by Ted C
Modified:
5 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch AppBannerManager on use of Unretained to use it's weakptr factory. It already uses the factory in one case, so using it here for consistency. BUG=NONE Committed: https://crrev.com/218a04b424934680f90aba877a97038673b4c39a Cr-Commit-Position: refs/heads/master@{#317181}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/browser/android/banners/app_banner_manager.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL
5 years, 10 months ago (2015-02-19 22:17:55 UTC) #2
gone
lgtm
5 years, 10 months ago (2015-02-19 22:22:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942633002/20001
5 years, 10 months ago (2015-02-19 23:46:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-20 00:10:32 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 00:11:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/218a04b424934680f90aba877a97038673b4c39a
Cr-Commit-Position: refs/heads/master@{#317181}

Powered by Google App Engine
This is Rietveld 408576698